US737: Two organisations for the minimal consortial model #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* NEW Filter list result for REST API by organisation. Signed-off-by: Johnny Mariéthoz <[email protected]>
* FIX Takes into account organisation constraints such as item type and locations for item generation. * NEW Corrects indentations of generated items. Signed-off-by: Johnny Mariéthoz <[email protected]>
BadrAly
approved these changes
May 20, 2019
Fixed |
* FIX Loans generation takes into account organisation contraints such as item type, location, patron types, etc. * FIX Takes into account organisation constraints such as item type, patron type, etc. for loan generation. Signed-off-by: Johnny Mariéthoz <[email protected]>
* NEW Restricts access to APIs for users of same organisation. Signed-off-by: Aly Badr <[email protected]>
* NEW Fixes issue when edit/delete buttons are displayed for users of other organisations. Signed-off-by: Aly Badr <[email protected]>
pronguen
reviewed
May 21, 2019
There was a problem hiding this comment.
Some problems identified:
- title of subject facet is not displayed
- confirmation message after creation of a circ pol is empty
- edition of a ressource of the other org by opening the direct URL:
- no error message for patron: try to open https://ilsdev.test.rero.ch/admin/records/patrons/12 in org 2
- no error message for item types: try to open https://ilsdev.test.rero.ch/admin/records/item_types/3 in org 2
- opens an empty form that cannot be saved: try to open https://ilsdev.test.rero.ch/admin/records/libraries/4 in org 2
- display of an item of the other org, with option to edit it (but it doesn't work): try to open https://ilsdev.test.rero.ch/items/887 in org 2
- items can be checked out between organisations
Please consider only changes that are related to this pull request.
this is due to the missing translations.
this is due to the missing translations.
can be solved by: #269 (to check)
Will be done in a new US.
|
Signed-off-by: Johnny Mariéthoz <[email protected]>
pronguen
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.