Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acquisition: complete fixtures for some resources #2802

Merged
merged 1 commit into from
Apr 4, 2022
Merged

acquisition: complete fixtures for some resources #2802

merged 1 commit into from
Apr 4, 2022

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Mar 31, 2022 •
edited
Loading

Co-Authored-by: Aly Badr [email protected]

How to test?

  • setup
  • check the admin interface for acqz orders/lines

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@BadrAly BadrAly added f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: acquisitions Related to the acquisition module labels Mar 31, 2022
@BadrAly BadrAly self-assigned this Mar 31, 2022
@github-actions github-actions bot added dev: fixtures Fixtures data used for ils.test and ilsdev.test developers From a developer point of view. and removed f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: acquisitions Related to the acquisition module labels Mar 31, 2022
@BadrAly BadrAly force-pushed the baa-fix-issue-2678 branch 3 times, most recently from fdfc6ac to 48ffd41 Compare April 4, 2022 09:09
acquisition: complete fixtures for resources
d6e6d7e 
* Complete acquisition for libraries.
* Adds complete fixtures for accounts, orders and order_lines.
* Adds optional way to load receipts, receipt_lines and invoices (needed for the BN project).
* Closes rero#2687

Co-Authored-by: Aly Badr <[email protected]>
@BadrAly BadrAly force-pushed the baa-fix-issue-2678 branch from 48ffd41 to d6e6d7e Compare April 4, 2022 09:12
@BadrAly BadrAly added the f: acquisitions Related to the acquisition module label Apr 4, 2022
@BadrAly BadrAly added this to the v1.10.0 milestone Apr 4, 2022
@BadrAly BadrAly merged commit 452f2e6 into rero:staging Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalRepond PascalRepond PascalRepond approved these changes

@lauren-d lauren-d lauren-d approved these changes

@rerowep rerowep rerowep approved these changes

@zannkukai zannkukai zannkukai approved these changes

@benerken benerken Awaiting requested review from benerken

Assignees

@BadrAly BadrAly

Labels
dev: fixtures Fixtures data used for ils.test and ilsdev.test developers From a developer point of view. f: acquisitions Related to the acquisition module
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.

Add fixtures: accounts, library acquisition settings, order and order lines
5 participants
@BadrAly @zannkukai @rerowep @lauren-d @PascalRepond