Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: fix the profile menu name #2776

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

jma
Copy link
Contributor

@jma jma commented Mar 21, 2022

  • Fixes a crash application when the invenio user does not have email
    address and is not a library user (patron or librarian).
  • Clears the user name session when the user is logged out.

Co-Authored-by: Johnny Mariéthoz [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

* Fixes a crash application when the invenio user does not have email
  address and is not a library user (patron or librarian).
* Clears the user name session when the user is logged out.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma force-pushed the maj-fix-user-without-email-profile-menu branch from bd6a08b to ff84223 Compare March 21, 2022 12:48
@jma jma requested review from Garfield-fr and vgranata March 21, 2022 12:48
@jma jma merged commit 5487535 into rero:staging Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants