Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

holding: better delete_standard_holdings_having_no_items #2724

Merged
merged 1 commit into from
Mar 10, 2022
Merged

holding: better delete_standard_holdings_having_no_items #2724

merged 1 commit into from
Mar 10, 2022

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Feb 24, 2022

  • Adds try, exception to delete of holding.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this Feb 24, 2022
@rerowep rerowep force-pushed the wep-better-delete_standard_holdings_having_no_items branch 3 times, most recently from 66bf87b to 57c97d8 Compare February 24, 2022 11:10
@rerowep rerowep force-pushed the wep-better-delete_standard_holdings_having_no_items branch from 57c97d8 to 3b93ffc Compare March 6, 2022 15:51
@PascalRepond PascalRepond added developers From a developer point of view. f: data About data model, importation, transformation, exportation of data, specific for bibliographic data labels Mar 7, 2022
@rerowep rerowep force-pushed the wep-better-delete_standard_holdings_having_no_items branch from 3b93ffc to 526433a Compare March 7, 2022 13:56
@github-actions github-actions bot removed f: data About data model, importation, transformation, exportation of data, specific for bibliographic data developers From a developer point of view. labels Mar 7, 2022
BadrAly
BadrAly approved these changes Mar 8, 2022
View reviewed changes
Copy link

@BadrAly BadrAly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase with the latest staging needed...

@rerowep rerowep force-pushed the wep-better-delete_standard_holdings_having_no_items branch from 526433a to 062d808 Compare March 10, 2022 10:22
@rerowep
holding: better delete_standard_holdings_having_no_items
e9a477b 
* Adds try, exception to delete of holding.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-better-delete_standard_holdings_having_no_items branch from 062d808 to e9a477b Compare March 10, 2022 19:55
@rerowep rerowep merged commit 4430978 into rero:staging Mar 10, 2022
@rerowep rerowep deleted the wep-better-delete_standard_holdings_having_no_items branch March 15, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@BadrAly BadrAly BadrAly approved these changes

@zannkukai zannkukai zannkukai approved these changes

@jma jma Awaiting requested review from jma

@vgranata vgranata Awaiting requested review from vgranata

Assignees

@rerowep rerowep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rerowep @zannkukai @BadrAly @lauren-d @PascalRepond