Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patron transaction event: fix decimal amount #2682

Merged
merged 1 commit into from
Feb 14, 2022
Merged

patron transaction event: fix decimal amount #2682

merged 1 commit into from
Feb 14, 2022

Conversation

zannkukai
Copy link
Contributor

  • Creates an extension to check if event amount contains a maximum of 2
    decimals.
  • Reorganizing some codes from PatronTransaction resource to be more
    readable/usable.
  • Closes Error when deleting a fine  #2602.

Co-Authored-by: Renaud Michotte [email protected]

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai requested review from BadrAly, lauren-d and jma February 7, 2022 14:50
@zannkukai zannkukai self-assigned this Feb 7, 2022
@zannkukai zannkukai added this to the v1.9.0 milestone Feb 7, 2022
@zannkukai zannkukai force-pushed the zan-fix-issue-2602 branch 3 times, most recently from 62f1408 to 13395f3 Compare February 8, 2022 06:23
@zannkukai zannkukai requested a review from lauren-d February 8, 2022 08:14
@jma
Copy link
Contributor

jma commented Feb 9, 2022 •
edited
Loading

Title commit changes suggestion:
PartonTransactionEvent: Fix decimal amount problem. -> patron transaction event: fix decimal amount

jma
jma approved these changes Feb 9, 2022
View reviewed changes
rero_ils/modules/patron_transaction_events/api.py Show resolved Hide resolved
rero_ils/modules/patron_transactions/api.py Show resolved Hide resolved
rero_ils/modules/patron_transactions/utils.py Show resolved Hide resolved
rero_ils/modules/patrons/api.py Outdated Show resolved Hide resolved
@zannkukai zannkukai force-pushed the zan-fix-issue-2602 branch 2 times, most recently from 1f022dc to 9d8b27c Compare February 9, 2022 13:24
@zannkukai zannkukai changed the title PartonTransactionEvent: Fix decimal amount problem. patron transaction event: fix decimal amount Feb 9, 2022
@zannkukai
patron transaction event: fix decimal amount
3cf2f8c 
* Creates an extension to check if event amount contains a maximum of 2
  decimals.
* Reorganizing some codes from `PatronTransaction` resource to be more
  readable/usable.
* Closes rero#2602.

Co-Authored-by: Renaud Michotte <[email protected]>
@pronguen pronguen merged commit c3aeebc into rero:staging Feb 14, 2022
@zannkukai zannkukai deleted the zan-fix-issue-2602 branch March 21, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@jma jma jma approved these changes

@BadrAly BadrAly Awaiting requested review from BadrAly

Assignees

@zannkukai zannkukai

Labels
None yet
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.

Error when deleting a fine
4 participants
@zannkukai @jma @lauren-d @pronguen