Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circulation: possibility to check-out in-transit items #267

Merged
merged 1 commit into from
May 6, 2019

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Apr 17, 2019

Signed-off-by: Aly Badr [email protected]

This two scenarios works:

  • checkout out an item (having no requests) with loan_status= ITEM_IN_TRANSIT_TO_HOUSE to any patron.

  • checkout out an item with loan_status= ITEM_IN_TRANSIT_FOR_PICKUP to any requested patron from any checkout library.

@pronguen
Copy link
Contributor

pronguen commented May 2, 2019

2 problems observed

Use case 1

  1. The item of Lib A is requested by Simonetta, with pick-up in Lib B
  2. The item is checked-out in Lib C for Simonetta, without action "receive"
  3. Check-out is allowed, but the request persist

Problem: the request of Simonetta should be satisfied at the check-out.

Use case 2

  1. The item of Lib A is requested by Simonetta, with pick-up in Lib B
  2. The item is checked-out in Lib C for Alain, without action "receive"
  3. Check-out is allowed

Problem: check-out should be allowed only for the first patron in the request queue (for now). Later, the librarian will have the option to override the limit.

This meen that the second scenario described in this pull request is not correct (not conform to #230):

checkout out an item with loan_status= ITEM_IN_TRANSIT_FOR_PICKUP to any requested patron from any checkout library

@BadrAly BadrAly force-pushed the baa-fix-issue-230 branch 2 times, most recently from d767bdc to 44430f7 Compare May 2, 2019 15:16
* FIX Fixes rero#230: allows checkout of in-transit items.

Signed-off-by: Aly Badr <[email protected]>
@BadrAly BadrAly force-pushed the baa-fix-issue-230 branch from 44430f7 to c6a0681 Compare May 6, 2019 08:11
@jma jma merged commit 6e4f68f into rero:dev May 6, 2019
@BadrAly BadrAly deleted the baa-fix-issue-230 branch May 28, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants