Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: add facets for inventory list #2612

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

lauren-d
Copy link
Contributor

@lauren-d lauren-d commented Dec 20, 2021

Co-Authored-by: Laurent Dubois [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

How to test?

  1. New added facets
  • Login as librarian and go to the Inventory List on professionnal view
  • The facet temporary_item_type and temporay_location will being displayed.
  • Try and check filtering

2 New fields into the export

  • In the Inventory List, try to find items on loan and export the results as csv.
  • The checkout_date and the due_date columns must be filled

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@lauren-d lauren-d added this to the v1.9.0 milestone Dec 20, 2021
@lauren-d lauren-d self-assigned this Dec 20, 2021
@lauren-d lauren-d force-pushed the lau-add-item-facets branch 5 times, most recently from 0e4bdc0 to 598611b Compare December 20, 2021 18:52
@lauren-d lauren-d force-pushed the lau-add-item-facets branch 2 times, most recently from 66df179 to c6e67a1 Compare January 7, 2022 20:56
@lauren-d lauren-d force-pushed the lau-add-item-facets branch from c6e67a1 to 09223f5 Compare January 7, 2022 21:07
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are missing.

@lauren-d lauren-d force-pushed the lau-add-item-facets branch from 09223f5 to 098a1ac Compare January 11, 2022 11:41
@lauren-d lauren-d requested a review from jma January 11, 2022 12:00
@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Jan 27, 2022

@lauren-d lauren-d force-pushed the lau-add-item-facets branch 2 times, most recently from 453f092 to e9f25a7 Compare February 4, 2022 07:27
* Adds temporary item type facet.
* Adds temporary location facet.
* Adds the checkout_date and the due_date fields to the export.
* Closes rero#2364.
* Closes rero#2611.

Co-Authored-by: Laurent Dubois <[email protected]>
@lauren-d lauren-d force-pushed the lau-add-item-facets branch from e9f25a7 to 10a55b1 Compare February 4, 2022 08:56
@lauren-d lauren-d merged commit 293ea0f into rero:staging Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants