Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

items: delete checked-in provisional items #2572

Merged

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Dec 1, 2021

  • Adds a daily task to delete checked-in provisional items having not associated fees.

Co-Authored-by: Aly Badr [email protected]

  • Migration instructions:

This task need to be enabled for the production instance

  • invenio reroils scheduler enable_tasks -n delete-provisional-items -v

Why are you opening this PR?

https://tree.taiga.io/project/rero21-reroils/task/2356

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@BadrAly BadrAly self-assigned this Dec 1, 2021
@github-actions github-actions bot added the f: circulation Concerns the circulation interface or backend label Dec 1, 2021
@BadrAly BadrAly force-pushed the baa-2356-task-delete-temp-items branch from a47f8ac to 8624be9 Compare December 1, 2021 14:15
@github-actions github-actions bot added developers From a developer point of view. and removed f: serials labels Dec 1, 2021
@BadrAly BadrAly added f: data migration Data migration from a legacy system or a previous version f: serials and removed developers From a developer point of view. labels Dec 1, 2021
@BadrAly BadrAly force-pushed the baa-2356-task-delete-temp-items branch from 8624be9 to bde2824 Compare December 1, 2021 14:28
@github-actions github-actions bot added developers From a developer point of view. and removed f: data migration Data migration from a legacy system or a previous version f: serials labels Dec 1, 2021
@rerowep rerowep self-requested a review December 1, 2021 14:28
rero_ils/modules/items/tasks.py Outdated Show resolved Hide resolved
rero_ils/modules/items/utils.py Outdated Show resolved Hide resolved
@BadrAly BadrAly force-pushed the baa-2356-task-delete-temp-items branch from bde2824 to 28814b9 Compare December 2, 2021 06:47
@BadrAly BadrAly requested a review from zannkukai December 2, 2021 06:47
@BadrAly BadrAly force-pushed the baa-2356-task-delete-temp-items branch from 28814b9 to c2fd3e9 Compare December 2, 2021 07:04
* Adds a daily task to delete checked-in provisional items having not associated fees.

Co-Authored-by: Aly Badr <[email protected]>

* Migration instructions:

This task need to be enabled for the production instance
- invenio reroils scheduler enable_tasks -n delete-provisional-items -v
@BadrAly BadrAly force-pushed the baa-2356-task-delete-temp-items branch from c2fd3e9 to a1ec289 Compare December 2, 2021 09:28
@BadrAly BadrAly merged commit b09523c into rero:US_request_holdings Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developers From a developer point of view. f: circulation Concerns the circulation interface or backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants