notifications: fix email_notification_type #2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `notification_settings` is not a required field for notifications. To prevent `KeyError` exceptions we have to use `get`. Co-Authored-by: Peter Weber <[email protected]>
rerowep
requested review from
Garfield-fr,
jma,
zannkukai,
BadrAly,
lauren-d and
vgranata
Garfield-fr
approved these changes
Nov 30, 2021
BadrAly
approved these changes
Nov 30, 2021
zannkukai
approved these changes
Nov 30, 2021
vgranata
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notification_settingsis not a required field for notifications.To prevent
KeyErrorexceptions we have to useget.Co-Authored-by: Peter Weber [email protected]
Why are you opening this PR?
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?
Code review check list