Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footer: fix missing version #2392

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Conversation

Garfield-fr
Copy link
Contributor

Co-Authored-by: Bertrand Zuchuat [email protected]

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@github-actions github-actions bot added the f: public ui Public interface, as opposed to the professional interface label Sep 17, 2021
@Garfield-fr Garfield-fr self-assigned this Sep 17, 2021
@Garfield-fr Garfield-fr added this to the v1.5.0 milestone Sep 17, 2021
Copy link
Contributor

@zannkukai zannkukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why the version wasn't print into footer.
version was a context argument for frontpage.html --> extending page.html --> including footer.html.

@Garfield-fr
Copy link
Contributor Author

I don't understand why the version wasn't print into footer.
version was a context argument for frontpage.html --> extending page.html --> including footer.html.

In the current version there is an error. The version number is displayed only on the home page, because the parameter must be passed to each template. With the "Global" version, it is no longer necessary to pass this parameter, because it is accessible through a global variable of jinja.

@Garfield-fr Garfield-fr changed the base branch from dev to v1.5.0 September 21, 2021 08:19
Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr merged commit cfe8259 into rero:v1.5.0 Sep 23, 2021
@Garfield-fr Garfield-fr deleted the zub-version-fix branch March 14, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: public ui Public interface, as opposed to the professional interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants