selfcheck: fix patron informations #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
f: circulation
sebdeleze
suggested changes
Jul 27, 2021
rero_ils/modules/selfcheck/api.py
Outdated
| @@ -48,6 +48,7 @@ def selfcheck_login(name, access_token, **kwargs): | |||
| """ | |||
| terminal = SelfcheckTerminal.find_terminal(name=name) | |||
| user = authorize_selfckeck_terminal(terminal, access_token, **kwargs) | |||
| print('user', user) | |||
rero_ils/modules/selfcheck/utils.py
Outdated
Comment on lines
98
to
103
| # Should never append, but can be imported from an old system | ||
| formated_address = formated_address.replace(r'\n', ' ') | ||
| formated_address = formated_address.replace(r'\r', ' ') | ||
| formated_address = formated_address.replace('\n', ' ') | ||
| formated_address = formated_address.replace('\r', ' ') | ||
| return formated_address |
lauren-d
approved these changes
Jul 27, 2021
jma
force-pushed
the
maj-fix-medvs-selfcheck
branch
2 times, most recently
from
ce6f828 to
1e2fcf4
Compare
* Sets `institution_id` to the patron organisation `pid`. * Rounds the fees to cents. * Fixes patron language, email, phone. * Removes CR chars `\n`, `\r` from the patron address. * Adds the `due_date` in a checkout response even if the item has been already checked out. Co-Authored-by: Johnny Mariéthoz <[email protected]> Co-Authored-by: Igor Milhit <[email protected]>
jma
force-pushed
the
maj-fix-medvs-selfcheck
branch
from
1e2fcf4 to
23be33c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
institution_idto the patron organisationpid.\n,\rfrom the patron address.due_datein a checkout response even if the item has beenalready checked out.
Co-Authored-by: Johnny Mariéthoz [email protected]
Co-Authored-by: Igor Milhit [email protected]
Why are you opening this PR?
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?
Code review check list