user interface: translations #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jma
requested changes
Mar 11, 2019
| @@ -118,13 +121,13 @@ | |||
| "Street": "Street", | |||
| "City": "City", | |||
| "No result found.": "No result found.", | |||
| "monday": "monday", | |||
There was a problem hiding this comment.
I'm not sure that the translation mechanism should be used to apply an uppercase. (this has been probably already used at other places). We can use CSS rules for this.
There was a problem hiding this comment.
Yes, in some place the CSS rule is a good method, but we already encounters issues with facets. It's then difficult to find the right selector to use ::first-letter, because we want only the first letter of the string to be uppercased, not each first letter of each words.
ui/admin/src/assets/i18n/en.json
Outdated
| @@ -99,17 +99,20 @@ | |||
| "has 1 patron attached": "has 1 patron attached", | |||
| "has # patrons attached": "has # patrons attached", | |||
| "The default record cannot be deleted": "The default record cannot be deleted", | |||
| "The recording contains settings": "The recording contains settings", | |||
| "The recording contains settings": "The record contains settings", | |||
There was a problem hiding this comment.
Should be changed in the original string?
ui/admin/src/assets/i18n/fr.json
Outdated
| "Closed": "Fermé", | ||
| "locations": "dépôt", | ||
| "no location": "pas de dépôt", | ||
| "{{ 'no location' | translate }}": "{{ 'no location' | translate }}", |
jma
approved these changes
Mar 12, 2019
BadrAly
approved these changes
Mar 12, 2019
ui/admin/src/assets/i18n/en.json
Outdated
| @@ -10,13 +10,13 @@ | |||
| "ITEM_ON_LOAN": "ITEM_ON_LOAN", | |||
There was a problem hiding this comment.
Item in circulation or Item checked-out
ui/admin/src/assets/i18n/en.json
Outdated
| @@ -10,13 +10,13 @@ | |||
| "ITEM_ON_LOAN": "ITEM_ON_LOAN", | |||
| "ITEM_RETURNED": "ITEM_RETURNED", | |||
| "ITEM_IN_TRANSIT_FOR_PICKUP": "ITEM_IN_TRANSIT_FOR_PICKUP", | |||
ui/admin/src/assets/i18n/en.json
Outdated
| @@ -10,13 +10,13 @@ | |||
| "ITEM_ON_LOAN": "ITEM_ON_LOAN", | |||
| "ITEM_RETURNED": "ITEM_RETURNED", | |||
| "ITEM_IN_TRANSIT_FOR_PICKUP": "ITEM_IN_TRANSIT_FOR_PICKUP", | |||
| "ITEM_IN_TRANSIT_TO_HOUSE": "ITEM_IN_TRANSIT_TO_HOUSE", | |||
| "ITEM_IN_TRANSIT_TO_HOUSE": "Item in transit to owning library", | |||
| "ITEM_AT_DESK": "ITEM_AT_DESK", | |||
ui/admin/src/assets/i18n/en.json
Outdated
| @@ -10,13 +10,13 @@ | |||
| "ITEM_ON_LOAN": "ITEM_ON_LOAN", | |||
| "ITEM_RETURNED": "ITEM_RETURNED", | |||
* NEW Updates the translations. * FIX Corrects some source strings. * FIX Corrects template code for translations. * FIX Ignores the angular builds when extracting messages to translate. * FIX Adds a favicon for apple touche devices. Signed-off-by: Igor Milhit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Igor Milhit [email protected]
How to test
pipenv run invenio collect(for the apple favicon), but you'll need to build the angluar app, so./scripts/bootstrapis the way...