Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin UI: fix and translations #208

Merged
merged 1 commit into from
Mar 7, 2019
Merged

admin UI: fix and translations #208

merged 1 commit into from
Mar 7, 2019

Conversation

iGormilhit
Copy link

  • NEW Adds a label for search views.
  • BETTER Improves the result count message.
  • BETTER Improves the patrons roles display.
  • FIX Fixes the layout for search views without facets.
  • FIX Fixes missing translations.
  • BETTER Improves patron types, item types, circulation policies fixtures.
  • FIX Pins isort to >=4.3.5,<4.3.10
  • Corrects some typos.
  • Removes a remain JSON print on the item detailed view template.

Signed-off-by: Igor Milhit [email protected]


To test

  • ./script/bootstrap
  • ./script/setup
  • Check the translation in the professional UI.
  • Check the layout in the professional UI, with or without facets.
  • Check the display of patron roles in the professional UI patrons search (brief views).
  • Check the patron types, item types and circulation policies fixtures (name and description).

Copy link

@BadrAly BadrAly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the UI patrons search, brief view:

  • When you click on patron to display patron info. The patron type ID is displayed instead of patron type name
  • When you click on librarian to display library info. The library ID is displayed instead of library name

@iGormilhit
Copy link
Author

@BadrAly On the patron ID, library ID, and also item type ID, you're right. I may be wrong, but I think that serializers are needed to have this data in the record in the first place, which I didn't edit or write.

@BadrAly
Copy link

BadrAly commented Mar 6, 2019

New names of itty, ptty and cipo are better than before.
Ok, that is it from my side 👍

* NEW Adds a label for search views and remove placeholders.
* BETTER Improves the result count message.
* BETTER Improves the patrons roles display.
* BETTER Improves the editor view title.
* FIX Fixes the layout for search views without facets.
* FIX Adds title on the delete and edit icons, and fixes order.
* FIX Fixes missing translations.
* BETTER Improves patron types, item types, circulation policies fixtures.
* FIX Pins isort to >=4.3.5,<4.3.10
* Corrects some typos.
* Removes a remain JSON print on the item detailed view template.

Signed-off-by: Igor Milhit <[email protected]>
@iGormilhit iGormilhit merged commit 3c5e408 into rero:dev Mar 7, 2019
@iGormilhit iGormilhit deleted the admin-ui-fixes-and-translations branch March 13, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants