DATA: $ref for mef persons #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerowep
force-pushed
the
resolveref
branch
15 times, most recently
from
e603485 to
23d8a73
Compare
jma
requested changes
Mar 1, 2019
rero_ils/modules/documents/dojson/contrib/marc21tojson/model.py
Outdated
Show resolved
Hide resolved
rero_ils/modules/documents/dojson/contrib/marc21tojson/model.py
Outdated
Show resolved
Hide resolved
rero_ils/modules/documents/jsonschemas/documents/document-v0.0.1.json
Outdated
Show resolved
Hide resolved
rerowep
force-pushed
the
resolveref
branch
6 times, most recently
from
feb5352 to
865fbb0
Compare
|
!!!!!! ATTENTION !!!!!!! |
iGormilhit
approved these changes
Mar 5, 2019
rerowep
force-pushed
the
resolveref
branch
4 times, most recently
from
fbe2796 to
e06fc72
Compare
jma
requested changes
Mar 13, 2019
| mef_url = hits[0].get('links').get('self') | ||
| mef_url = mef_url.replace(DEV_HOST, PROD_HOST) | ||
| else: | ||
| print( |
There was a problem hiding this comment.
you can perhaps use logger or click
There was a problem hiding this comment.
I have to redirect to STDERR
rero_ils/modules/ext.py
Outdated
| @@ -87,3 +87,12 @@ def register_signals(self): | |||
| from .apiharvester.signals import apiharvest_part | |||
| from .mef_persons.receivers import publish_api_harvested_records | |||
| apiharvest_part.connect(publish_api_harvested_records, weak=False) | |||
|
|
|||
| from invenio_records.signals import after_record_delete, \ | |||
There was a problem hiding this comment.
ok but why not make the code better?
rerowep
force-pushed
the
resolveref
branch
4 times, most recently
from
7de97e1 to
e294fea
Compare
* NEW: $ref to mef in the json file * BETTER: detailed view document * BETTER: detailed view person * NEW: proxy to mef * NEW: new 10k extraction of documents * NEW: indexing into mef_persons Signed-off-by: Peter Weber <[email protected]> Signed-off-by: Peter Weber <[email protected]>
jma
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!!!!! ATTENTION !!!!!!!
following env variables have to be set:
For testing the
bootstapandsetupscript must be lanched!