Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sip2: use item barcode instead item pid #2029

Merged
merged 1 commit into from
Jun 16, 2021
Merged

sip2: use item barcode instead item pid #2029

merged 1 commit into from
Jun 16, 2021

Conversation

lauren-d
Copy link
Contributor

@lauren-d lauren-d commented Jun 11, 2021 •
edited
Loading

  • Fixes patron address for sip2.
  • Uses item barcode instead of item pid.

Lauren-D [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@lauren-d lauren-d self-assigned this Jun 11, 2021
@lauren-d lauren-d force-pushed the lau-fix-sip2-patron-address branch from f374861 to b3a210e Compare June 11, 2021 16:24
iGormilhit
iGormilhit reviewed Jun 14, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit component: I think that circulation or SIP2 was used, most of the time. And for this one specifically, it could be dependencies. This is not so much important, of course.

@lauren-d lauren-d force-pushed the lau-fix-sip2-patron-address branch from b3a210e to 96b3005 Compare June 14, 2021 08:49
@lauren-d lauren-d changed the title selfcheck: update dependencies SIP2: update dependencies Jun 14, 2021
@lauren-d lauren-d force-pushed the lau-fix-sip2-patron-address branch 4 times, most recently from c435525 to ca0b4c4 Compare June 14, 2021 15:14
@lauren-d lauren-d requested a review from iGormilhit June 14, 2021 16:02
@lauren-d lauren-d changed the title SIP2: update dependencies sip2: update dependencies Jun 15, 2021
@lauren-d lauren-d force-pushed the lau-fix-sip2-patron-address branch 2 times, most recently from ba59365 to 373586e Compare June 15, 2021 14:02
@lauren-d
sip2: use item barcode instead item pid
aef787f 
* Fixes patron address for sip2.
* Uses item barcode instead of item pid.

Lauren-D <[email protected]>
@lauren-d lauren-d force-pushed the lau-fix-sip2-patron-address branch from 373586e to aef787f Compare June 15, 2021 14:16
@lauren-d lauren-d changed the title sip2: update dependencies sip2: use item barcode instead item pid Jun 15, 2021
@iGormilhit iGormilhit added this to the v1.3.0 milestone Jun 16, 2021
@lauren-d lauren-d merged commit b737a22 into rero:dev Jun 16, 2021
@lauren-d lauren-d deleted the lau-fix-sip2-patron-address branch September 6, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit approved these changes

@zannkukai zannkukai zannkukai approved these changes

@benerken benerken benerken approved these changes

@rerowep rerowep rerowep approved these changes

Assignees

@lauren-d lauren-d

Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lauren-d @iGormilhit @zannkukai @benerken @rerowep