Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix external tests #1998

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Jun 8, 2021

The tests where using the wrong REDIS for external tests.

  • Allows running of external tests without starting of production docker containers.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this Jun 8, 2021
@rerowep rerowep force-pushed the wep-fix-external-tests branch 2 times, most recently from a59dd59 to e51ce63 Compare June 8, 2021 07:03
@rerowep rerowep force-pushed the wep-fix-external-tests branch from e51ce63 to 830d571 Compare June 8, 2021 07:25
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit body: s/where/were/

@rerowep rerowep force-pushed the wep-fix-external-tests branch from 830d571 to ea1c2d3 Compare June 9, 2021 06:02
The tests were using the wrong REDIS for external tests.

* Allows running of external tests without starting of production docker containers.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-fix-external-tests branch from ea1c2d3 to 1bf7a05 Compare June 9, 2021 06:03
@rerowep rerowep merged commit 6e781e8 into rero:dev Jun 9, 2021
@rerowep rerowep deleted the wep-fix-external-tests branch June 14, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants