Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serials: fix issue.status_date field update #1911

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

zannkukai
Copy link
Contributor

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai added bug Breaks something but is not blocking f: serials labels May 11, 2021
@zannkukai zannkukai self-assigned this May 11, 2021
@zannkukai zannkukai force-pushed the zan-fix-issue-1654 branch from 27a3634 to a49857f Compare May 11, 2021 05:56
@iGormilhit iGormilhit added this to the v1.3.0 milestone May 11, 2021
@iGormilhit iGormilhit changed the title issue: fix issue.status_date field update serials: fix issue.status_date field update May 11, 2021
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message proposition:

serials: fix issue.status_date field update

* Ensure that the `issue.status_date` field is updated when an issue is
  created/updated.
* Closes rero#1654.

rero_ils/modules/items/api/record.py Outdated Show resolved Hide resolved
@zannkukai zannkukai requested review from lauren-d and iGormilhit May 11, 2021 11:23
@zannkukai zannkukai force-pushed the zan-fix-issue-1654 branch from a49857f to 42d6da0 Compare May 11, 2021 11:23
* Ensure that the `issue.status_date` field is updated when an issue is
  created/updated.
* Closes rero#1654.

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai force-pushed the zan-fix-issue-1654 branch from 42d6da0 to f82e1cc Compare June 2, 2021 11:21
@zannkukai zannkukai merged commit 62fed77 into rero:dev Jun 7, 2021
@zannkukai zannkukai deleted the zan-fix-issue-1654 branch June 7, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking f: serials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receive an issue: confusion between the status date and the date of receipt
5 participants