Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documents: fix json schema for identifier #1862

Merged
merged 1 commit into from
May 3, 2021
Merged

documents: fix json schema for identifier #1862

merged 1 commit into from
May 3, 2021

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Apr 30, 2021 •
edited
Loading

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this Apr 30, 2021
@rerowep rerowep added bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor labels Apr 30, 2021
@iGormilhit iGormilhit added the f: data About data model, importation, transformation, exportation of data, specific for bibliographic data label May 3, 2021
@jma jma added this to the v1.2.0 milestone May 3, 2021
@rerowep rerowep force-pushed the wep-fix-identifiedby branch from 31607a9 to 569a1be Compare May 3, 2021 09:02
@rerowep rerowep changed the title documents: fix json schema for identifiedBy documents: fix json schema for identifier May 3, 2021
@rerowep rerowep force-pushed the wep-fix-identifiedby branch 3 times, most recently from 118a8e2 to 18dcd9a Compare May 3, 2021 13:59
@rerowep
documents: fix json schema for identifier
26bdd85 
* Work around for a problem in `ngx-formly` with required values in an
  object in oneOf: ngx-formly/ngx-formly#2826

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-fix-identifiedby branch from 18dcd9a to 26bdd85 Compare May 3, 2021 14:09
@jma jma merged commit 08a1bed into rero:dev May 3, 2021
@rerowep rerowep deleted the wep-fix-identifiedby branch May 4, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit Awaiting requested review from iGormilhit

@jma jma Awaiting requested review from jma

@lauren-d lauren-d Awaiting requested review from lauren-d

@zannkukai zannkukai Awaiting requested review from zannkukai

Assignees

@rerowep rerowep

Labels
bug Breaks something but is not blocking f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: editor Concerns editor based on JSON schema AND custom editor
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rerowep @jma @iGormilhit