-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
items: improve response time for csv export #1842
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c69b84
to
3732771
Compare
f02285c
to
51255b1
Compare
7 tasks
f9401a2
to
48f6d49
Compare
00db7de
to
8a51793
Compare
e22d8aa
to
812794d
Compare
4891da7
to
975c04b
Compare
benerken
approved these changes
May 1, 2021
iGormilhit
approved these changes
May 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message approved.
975c04b
to
43deba6
Compare
zannkukai
suggested changes
May 3, 2021
43deba6
to
1670b3a
Compare
1670b3a
to
b0296ae
Compare
|
According to Joëlle and Benoit, it's not necessary to have that in the export
Maybe that could be done in a spreadsheet ? |
zannkukai
approved these changes
May 4, 2021
jma
approved these changes
May 4, 2021
b0296ae
to
079ac0b
Compare
rerowep
approved these changes
May 5, 2021
079ac0b
to
01beedd
Compare
The CSV export of the inventory list has an important waiting time. With this commit, we try to improve the response time. * Uses ciso8601 to parse date fields instead `format_date_filter`. * Adds new api endpoint for inventory list. * Uses streaming to process download csv file. * Uses bunch request to reduce elasticsearch calls. * Adds some fields in csv file. * Closes rero#1456. * Closes rero#1329. Co-Authored-by: Laurent Dubois <[email protected]>
01beedd
to
bb0fffd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Improvement of an existing feature
f: circulation
Concerns the circulation interface or backend
f: search
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSV export of the inventory list has an important waiting time.
With this commit, we try to improve the response time.
format_date_filter
.Co-Authored-by: Laurent Dubois [email protected]
Why are you opening this PR?
Dependencies
My PR depends on
rero-ils#<xx>
's PR(s):Code review check list