Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translations: fix the extraction process #1836

Merged
merged 1 commit into from
Apr 20, 2021
Merged

translations: fix the extraction process #1836

merged 1 commit into from
Apr 20, 2021

Conversation

iGormilhit
Copy link

  • Restores the format syntax instead of the f-string, because babel
    does not support it, thus failing in extracting the strings.

Co-Authored-by: Igor Milhit [email protected]

Why are you opening this PR?

  • Because the message extraction is broken on the dev branch.

How to test?

  • Try to extract the translation strings.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

* Restores the format syntax instead of the f-string, because babel
  does not support it, thus failing in extracting the strings.

Co-Authored-by: Igor Milhit <[email protected]>
@iGormilhit iGormilhit added the translations Translations label Apr 19, 2021
@iGormilhit iGormilhit self-assigned this Apr 19, 2021
@iGormilhit iGormilhit requested a review from zannkukai April 19, 2021 14:16
@iGormilhit iGormilhit added this to the v1.2.0 milestone Apr 19, 2021
@iGormilhit iGormilhit marked this pull request as ready for review April 19, 2021 14:53
@iGormilhit iGormilhit merged commit 616ebd8 into rero:dev Apr 20, 2021
@iGormilhit iGormilhit deleted the fix-extract-message branch May 6, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants