Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US1889 patron edit personnal data #1742

Merged
merged 5 commits into from
Mar 3, 2021
Merged

Conversation

jma
Copy link
Contributor

@jma jma commented Mar 3, 2021

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

jma and others added 5 commits March 1, 2021 09:22
* Removes the RERO ID menu.
* Adds a "My Account" menu, which is the patron profile for patron and
  invenio users for others.
* Removes breadcrumbs in the profile settings view.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
* Adds a new API `/api/user_info/<username_or_email>` to get the
  information of a potential future patron or professional.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
The user profiles is duplicated on the patron and profile record.  The
synchronization is done in the both direction, either when the user
change his/her profile or when a professional change the user
informations in the patron editor.

This commit changes this behavior. The data are modified only on the
profile database and synchronized in only one direction: from profile to
patron.

* Adds new utilities functions to support the current fixtures users
  data format.
* Removes all patron without email fixtures.
* Removes loans anonymization from the patron update/creation.
* Adds a new 'user' resource to manage the user profiles. It contains
  the user personal data as opposed to the patron data that are link to
  a specific organisation.
* Writes a REST API:
  * A GET, POST, PUT methods to create, update and retrieves the patron
    personal information.
  * A search endpoint to retrieve the patron personal information given
    an email or a username.
* Creates units testing.
* Centralizes several views and methods in a specific `User` python
  class.
* Disables the validation email for freshly created user.
* Uses the standard ngx-formly `widget` field for the user JSON schema.

Co-Authored-by: Aly Badr <[email protected]>
Co-Authored-by: Johnny Mariéthoz <[email protected]>
* Replaces the phone field by home, business, mobile, other phone fields
  in the user data model.
* Adds country and gender fields in the user data model.
* Adds 3 invenio-userprofiles configuration to specify the list of
  countries, the default country and the read only fields.
* Makes the barcode repetitive.
* Removes all user fields from the patron data model.
* Adds the second address, the local code, the source fields in the
  patron data model.
* Closes #1724, #1634, #1615, #1490, #1467, #1318, #1384, #1670.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma merged commit 30bf6ec into dev Mar 3, 2021
@jma jma deleted the maj-US1889-patron-edit-personnal-data branch March 10, 2021 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant