ILL request: fix permissions #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benerken
approved these changes
Feb 22, 2021
AoNoOokami
reviewed
Feb 23, 2021
iGormilhit
suggested changes
Feb 23, 2021
* Fixes permissions when the current user has librarian AND patron roles, thus preventing him or her to view/edit an ILL requests on the professional interface. * Closes rero#1709. Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai
force-pushed
the
zan-fix-issue-1709
branch
from
f6c99b2 to
9984dbf
Compare
rerowep
approved these changes
Feb 25, 2021
lauren-d
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the current user had role librarian AND role patron, it couln't
view/edit an ILL requests into the admin interface.
Closes #1709.
Co-Authored-by: Renaud Michotte [email protected]
Code review check list