Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document: fix call number display. #1568

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

zannkukai
Copy link
Contributor

In the 'get' tab from document detailed view, the item call number was
included into a too large column. It caused a display problem because
label and data were splitted in two separate lines.

Co-Authored-by: Renaud Michotte [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

In the 'get' tab from document detailed view, the item call number was
included into a too large column. It caused a display problem because
label and data were splitted in two separate lines.

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai added this to the v1.0.0 milestone Dec 16, 2020
@zannkukai zannkukai self-assigned this Dec 16, 2020
@iGormilhit iGormilhit modified the milestones: v1.0.0, v0.15.0 Dec 16, 2020
@iGormilhit iGormilhit marked this pull request as ready for review December 16, 2020 12:05
@zannkukai zannkukai merged commit 3c9b22d into rero:dev Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants