Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library creation #156

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Library creation #156

merged 1 commit into from
Dec 17, 2018

Conversation

Garfield-fr
Copy link
Contributor

Libraries: Library creation

  • NEW: library creation by admin ui
  • BETTER: Refactoring library form to implement creation

To test:

  • bootstrap script
  • Check create function with button Create on list

@Garfield-fr Garfield-fr force-pushed the library-creation branch 2 times, most recently from 037e71a to a11dc1b Compare December 13, 2018 12:59
BadrAly
BadrAly approved these changes Dec 17, 2018
View reviewed changes
Copy link

@BadrAly BadrAly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

application test: ok

iGormilhit
iGormilhit suggested changes Dec 17, 2018
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should have only one commit. I think Form validation can be safely dropped, as it's already merged into master.

Except this, from a functional point of view, it works smoothly. The form is very clear.

@Garfield-fr @rerowep
Libraries: Library creation
7f273ef 
* NEW: library creation by admin ui
* BETTER: Refactoring library form to implement creation

Co-authored-by: Peter Weber <[email protected]>
Signed-off-by: Bertrand Zuchuat <[email protected]>
@rerowep rerowep merged commit bc3f9a2 into rero:master Dec 17, 2018
@Garfield-fr Garfield-fr deleted the library-creation branch December 17, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BadrAly BadrAly BadrAly approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@jma jma Awaiting requested review from jma

@NicolasLabat NicolasLabat Awaiting requested review from NicolasLabat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garfield-fr @iGormilhit @BadrAly @rerowep