items: inherit holdings first call_number #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadrAly
force-pushed
the
baa-inherit-call-number
branch
2 times, most recently
from
257dec4 to
3f5d180
Compare
iGormilhit
reviewed
Dec 3, 2020
BadrAly
force-pushed
the
baa-inherit-call-number
branch
from
3f5d180 to
e3085ac
Compare
BadrAly
requested review from
zannkukai,
AoNoOokami,
Garfield-fr and
lauren-d
Garfield-fr
approved these changes
Dec 10, 2020
zannkukai
requested changes
Dec 10, 2020
BadrAly
force-pushed
the
baa-inherit-call-number
branch
from
e3085ac to
c5e987c
Compare
zannkukai
requested changes
Dec 10, 2020
iGormilhit
added
f: data
iGormilhit
suggested changes
Dec 14, 2020
There was a problem hiding this comment.
Commit message proposition:
items: inherit holdings first call_number
For items of type `issue`, the parent holdings first call_number is
displayed when the item has no first call_number. This call number is
inherited in the following screens in the public interface:
* Document details view.
* Patron profile: loans, requests, history tabs.
* Collection details view.
* Generated notifications.
* Closes #1288.
8633e6d to
41f3806
Compare
zannkukai
approved these changes
Dec 14, 2020
AoNoOokami
approved these changes
Dec 14, 2020
BadrAly
force-pushed
the
baa-inherit-call-number
branch
from
41f3806 to
8b73d29
Compare
iGormilhit
approved these changes
Dec 15, 2020
BadrAly
force-pushed
the
baa-inherit-call-number
branch
from
8b73d29 to
aa07464
Compare
lauren-d
approved these changes
Dec 15, 2020
BadrAly
force-pushed
the
baa-inherit-call-number
branch
from
aa07464 to
885ee6a
Compare
BadrAly
force-pushed
the
baa-inherit-call-number
branch
from
885ee6a to
c516050
Compare
zannkukai
approved these changes
Jan 11, 2021
BadrAly
force-pushed
the
baa-inherit-call-number
branch
2 times, most recently
from
4d3997c to
377f7ed
Compare
For items of type `issue`, the parent holdings first call_number is displayed when the item has no first call_number. This call number is inherited in the following screens in the public interface: * Document details view. * Patron profile: loans, requests, history tabs. * Collection details view. * Late issues and inventory CSV exports. * Generated notifications. * Closes rero#1288. Co-Authored-by: Aly Badr <[email protected]>
BadrAly
force-pushed
the
baa-inherit-call-number
branch
from
377f7ed to
0a8d90c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For items of type
issue, the parent holdings first call_number isdisplayed when the item has no first call_number. This call number is
inherited in the following screens in the public interface:
Document details view.
Patron profile: loans, requests, history tabs.
Collection details view.
Late issues and inventory CSV exports.
Generated notifications.
Closes The issue call number should be generated according to the holdings call number. #1288.
Co-Authored-by: Aly Badr [email protected]
Why are you opening this PR?
https://tree.taiga.io/project/rero21-reroils/task/1896?kanban-status=1224894
Dependencies
How to test?
Code review check list