circulation: fix transaction end_date. #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
zan-fix-transaction-requested-on-closed-date
branch
from
458a975 to
25665b5
Compare
lauren-d
approved these changes
Dec 1, 2020
BadrAly
approved these changes
Dec 1, 2020
zannkukai
force-pushed
the
zan-fix-transaction-requested-on-closed-date
branch
from
25665b5 to
b613d31
Compare
zannkukai
force-pushed
the
zan-fix-transaction-requested-on-closed-date
branch
from
b613d31 to
157ebce
Compare
iGormilhit
suggested changes
Dec 3, 2020
There was a problem hiding this comment.
Commit message minor corrections:
circulation: fix transaction end_date
If a transaction end date is used for a checkout, it's possible that
this date is a non business day of the related library. In this
case, the transaction end_date will be updated on the next business day.
157ebce to
a309bf7
Compare
If a transaction end date is used for a checkout, it's possible that this date is a non business day of the related library. In this case, the transaction end_date will be updated on the next business day. Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai
force-pushed
the
zan-fix-transaction-requested-on-closed-date
branch
from
a309bf7 to
c7cfb98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a transaction end date is used for a checkout, it's possible that
this date is a business closed date for the related library. In this
case, the transaction end_date will be update on the next open day.
Co-Authored-by: Renaud Michotte [email protected]
Code review check list