Libraries: Form Validation #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
force-pushed
the
form-validation
branch
4 times, most recently
from
193c416 to
8d571fc
Compare
|
(perhaps just for info) Opening hours : a control is done when end time is less than start time. However, when adding a period, there is no control between periods. It is for example possible to submit : |
|
Opening hours : it is possible to submit a non-correct format. |
|
(Enhancement?) Date exceptions : when using the "repeat" action, it could be interesting to display the end date. For example : if the library is closed on Sunday starting the 02.12 for 16 weeks, it is displayed "weekly=16" but we have no information about the end date precisely. |
Garfield-fr
force-pushed
the
form-validation
branch
2 times, most recently
from
d037116 to
a91553c
Compare
Garfield-fr
force-pushed
the
form-validation
branch
6 times, most recently
from
23e2a2a to
744012d
Compare
BadrAly
approved these changes
Dec 12, 2018
reropag
approved these changes
Dec 12, 2018
NicolasLabat
approved these changes
Dec 12, 2018
jma
reviewed
Dec 12, 2018
Co-authored-by: Peter Weber <[email protected]> Signed-off-by: Bertrand Zuchuat <[email protected]>
Garfield-fr
force-pushed
the
form-validation
branch
from
744012d to
ac768a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test:
Run the scripts
bootstrapandsetupCheck form validation on edit.
Fields Required:
Co-authored-by: Peter Weber [email protected]
Signed-off-by: Bertrand Zuchuat [email protected]