Library: date exceptions #151
Conversation
There was a problem hiding this comment.
I'm sure that you've thought about the following points, but my comments on the UI are:
- On the detailed view, I would put color (X in red, ✔️ in green).
- In the exception list view, I wouldn't display "unique", but only if it's yearly, monthly, etc. The interval value isn't easy to understand.
- When editing, I couldn't select yearly and put a value. After saving it's always "unique".
- Period days → Days period
Otherwise, I find the UI nice to use. Cool.
And, is this PR up to date with the master branch? I don't see the admin layout commit.
rerowep
force-pushed
the
date-exceptions
branch
5 times, most recently
from
dc0688d to
13f95d4
Compare
* NEW: add date exceptions in the library JSON schema * NEW: update editor to manage library Co-Authored-by: Bertrand Zuchuat <[email protected]> Co-Authored-by: Nicolas Labat <[email protected] Signed-off-by: Peter Weber <[email protected]>
rerowep
force-pushed
the
date-exceptions
branch
from
13f95d4 to
54737b9
Compare
| @@ -66,6 +66,16 @@ def save_library(data, record_type, record_class, parent_pid=None): | |||
| library = record_class.get_record_by_pid(pid) | |||
| library.update(data, dbcommit=False, reindex=False) | |||
| else: | |||
| if 'opening_hours' not in data: | |||
| data['opening_hours'] = [ | |||
There was a problem hiding this comment.
can be replaced by a comprehension list such as [{"day": day, "is_open": False, "times": []} for day in ['monday', 'thuesday', etc]]
There was a problem hiding this comment.
Will be deleted with task #743
| [bsValue]="bsValue" | ||
| [bsConfig]="{ containerClass: 'theme-default' }"> | ||
| <div class="input-group-append"> | ||
| <span class="input-group-text" id="basic-addon2" (click)="dp.toggle()"> |
| onPeriodChange(period) { | ||
| this.form.is_period.setValue(period); | ||
| if (period) { | ||
| for (let i = 0; i < this.form.times.length; i++) { |
There was a problem hiding this comment.
does it means this.form.times = []?
There was a problem hiding this comment.
No, it means count of time in times
| } | ||
| } | ||
|
|
||
| onIsOpenChange(isopen) { |
| } | ||
|
|
||
| get title() { return this.form.title; } | ||
| get is_period() { return this.form.is_period; } |
There was a problem hiding this comment.
is_period => isPeriod, if you agree check all the code
|
|
||
| sortExceptions() { | ||
| this.exception_dates.sort(function(a, b) { | ||
| const keyA = new Date(a.start_date); |
There was a problem hiding this comment.
moment can be used. Something like: return moment(a.start_date).substract(moment(b.start_date))
Co-Authored-by: Bertrand Zuchuat [email protected]
Co-Authored-by: Nicolas Labat <[email protected]
Signed-off-by: Peter Weber [email protected]
How to test:
Run the scripts
bootstrapandsetupThe library "Bibliothèque cantonale valdôtaine, site de Pont-Saint-Martin"
has predefined exception dates.