Circulation: invenio-circulation integration #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadrAly
force-pushed
the
baa-#-711-ils-refactoring
branch
8 times, most recently
from
591831f to
c0def98
Compare
BadrAly
requested review from
rerowep,
Garfield-fr,
iGormilhit and
NicolasLabat
rerowep
requested changes
Nov 20, 2018
BadrAly
force-pushed
the
baa-#-711-ils-refactoring
branch
9 times, most recently
from
e7ba5ba to
43a5150
Compare
BadrAly
force-pushed
the
baa-#-711-ils-refactoring
branch
7 times, most recently
from
3ae52bc to
a80b55e
Compare
BadrAly
changed the title
BadrAly
force-pushed
the
baa-#-711-ils-refactoring
branch
7 times, most recently
from
6d2e591 to
21b6bbf
Compare
jma
reviewed
Dec 10, 2018
| 'term', | ||
| **{"patron_type_pid": self.pid} | ||
| ).source().scan())) | ||
|
|
There was a problem hiding this comment.
can be rewritten as:
return PatronsSearch().filter('term', **{'patron_type_pid': self.pid}).count() == 0| 'term', | ||
| **{"organisation_pid": organisation_pid} | ||
| ).source().scan() | ||
| patron_type = ( |
There was a problem hiding this comment.
can be rewritten as:
return next(PatronTypeSearch()
.filter('term', **{'patron_type_name': name})
.filter('term', **{'organisation_pid': organisation_pid}).scan())| @@ -65,6 +65,16 @@ def i18n_to_str(language): | |||
| def resolve_function(function_name): | |||
| """Execute resolve function.""" | |||
| result = [] | |||
| if function_name == 'libraries_pids_names': | |||
| from rero_ils.modules.libraries_locations.api import Library | |||
| @@ -65,6 +65,16 @@ def i18n_to_str(language): | |||
| def resolve_function(function_name): | |||
| """Execute resolve function.""" | |||
| result = [] | |||
| if function_name == 'libraries_pids_names': | |||
| from rero_ils.modules.libraries_locations.api import Library | |||
| for id in Library.get_all_ids(): | |||
There was a problem hiding this comment.
please use _id instead of id as it is a reserved word in python
| @@ -65,6 +65,16 @@ def i18n_to_str(language): | |||
| def resolve_function(function_name): | |||
rerowep
previously approved these changes
Dec 10, 2018
NicolasLabat
approved these changes
Dec 10, 2018
NEW: circulation apis refactoring Co-Authored-by: Aly Badr [email protected] Co-Authored-by: Gianni Pante [email protected]
BadrAly
force-pushed
the
baa-#-711-ils-refactoring
branch
from
21b6bbf to
1732ff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW: circulation apis refactoring
Co-Authored-by: Aly Badr [email protected]
Co-Authored-by: Gianni Pante [email protected]
To Test:
application_test:
Go through all the functionalities you can on the localhost:5000 except the circulation_ui.