Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontpage: fix patron profile link translation #1413

Merged

Conversation

AoNoOokami
Copy link
Contributor

@AoNoOokami AoNoOokami commented Nov 6, 2020

Co-Authored-by: Alicia Zangger [email protected]

Why are you opening this PR?

To close issue mentioned above.

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

N/A

How to test?

See issue description

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@AoNoOokami AoNoOokami self-assigned this Nov 6, 2020
@AoNoOokami AoNoOokami force-pushed the zaa-#1786-patron-profile-translation branch 4 times, most recently from 15f7663 to 4d89945 Compare November 9, 2020 14:23
@AoNoOokami AoNoOokami changed the title issue: fix the translation of the patron profile link ui: fix translation issues Nov 9, 2020
@AoNoOokami AoNoOokami force-pushed the zaa-#1786-patron-profile-translation branch 2 times, most recently from e89a12f to 6bc51ec Compare November 10, 2020 10:21
@AoNoOokami AoNoOokami added this to the v0.15.0 milestone Nov 10, 2020
@AoNoOokami AoNoOokami force-pushed the zaa-#1786-patron-profile-translation branch from 6bc51ec to 15a62e1 Compare November 10, 2020 15:16
@AoNoOokami AoNoOokami changed the title ui: fix translation issues frontpage: fix patron profile link translation Nov 10, 2020
@AoNoOokami AoNoOokami force-pushed the zaa-#1786-patron-profile-translation branch from 15a62e1 to 339c755 Compare November 11, 2020 07:32
@AoNoOokami AoNoOokami modified the milestones: v0.15.0, v0.14.0 Nov 11, 2020
@AoNoOokami AoNoOokami added the translations Translations label Nov 11, 2020
* Fixes the translation of the patron profile link.
* Closes rero#1283.

Co-Authored-by: Alicia Zangger <[email protected]>
@AoNoOokami AoNoOokami force-pushed the zaa-#1786-patron-profile-translation branch from 339c755 to e0fdc8e Compare November 11, 2020 07:42
@AoNoOokami AoNoOokami modified the milestones: v0.14.0, v0.15.0 Nov 11, 2020
@AoNoOokami AoNoOokami marked this pull request as ready for review November 18, 2020 08:32
@AoNoOokami AoNoOokami modified the milestones: v0.15.0, v0.14.1 Nov 18, 2020
@AoNoOokami AoNoOokami merged commit ce087b1 into rero:dev Nov 18, 2020
@AoNoOokami AoNoOokami deleted the zaa-#1786-patron-profile-translation branch December 4, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The link to the patron profile is not translated in the public interface.
3 participants