admin ui: angular skeleton #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iGormilhit
approved these changes
Nov 8, 2018
|
The side bar is shifted all the way up when you select Library settings or circulation settings. |
BadrAly
approved these changes
Nov 8, 2018
rerowep
reviewed
Nov 8, 2018
* NEW angular UI project * NEW admin views: circulation settings and library settings * FIX restore the missing `pipenv check` command during the tests * FIX remove useless debug flag for tests Co-Authored-by: Igor Milhit <[email protected]> Signed-off-by: Johnny Mariéthoz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipenv checkcommand during the testsSigned-off-by: Johnny Mariéthoz [email protected]
Co-Authored-by: Igor Milhit [email protected]