Package: requests upgrade #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iGormilhit
suggested changes
Nov 6, 2018
Pipfile
Outdated
| @@ -16,6 +16,7 @@ uwsgi = ">=2.0" | |||
| invenio-oaiharvester = {ref = "v1.0.0a4", git = "https://github.com/inveniosoftware/invenio-oaiharvester.git"} | |||
| pip = "<=18.0" | |||
| pipenv = "*" | |||
| requests = "==2.20.0" | |||
|
@BadrAly: As @jma suggested, you can use this PR to remove lines 38 and 39 in the Edit: |
* FIX: fixes vulnerability issues with requests package versions before 2.19.1 Signed-off-by: Aly Badr <[email protected]>
BadrAly
force-pushed
the
baa-fix-requests-package
branch
from
c3dbbc4 to
4ced3d3
Compare
iGormilhit
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aly Badr [email protected]
To Test:
./scripts/bootstrap
./run_tests.sh
"The Requests package before 2.19.1 sends an HTTP Authorization header to an http URI upon receiving a same-hostname https-to-http redirect, which makes it easier for remote attackers to discover credentials by sniffing the network"