Circulation policy: issues #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadrAly
requested review from
iGormilhit,
Garfield-fr,
NicolasLabat and
rerowep
|
Checkout duration in days set to "0" becomes "7" after saving when you reedit the rule. |
|
Create a new rule with settings : |
BadrAly
force-pushed
the
baa-fix-issues-127-125
branch
from
99b48ef to
aef805d
Compare
NicolasLabat
approved these changes
Oct 23, 2018
BadrAly
force-pushed
the
baa-fix-issues-127-125
branch
from
aef805d to
589a1e8
Compare
* FIX: closes rero#125, closes rero#127 Signed-off-by: Aly Badr <[email protected]>
BadrAly
force-pushed
the
baa-fix-issues-127-125
branch
from
589a1e8 to
957f88d
Compare
iGormilhit
approved these changes
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aly Badr [email protected]
To test:
Display the list of available circulation policies (cipo), edit or a dd a new one, you should not be able to add a negative value and now the days are marked with a "day(s)"