Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: cleaning #122

Merged
merged 1 commit into from
Oct 18, 2018
Merged

frontend: cleaning #122

merged 1 commit into from
Oct 18, 2018

Conversation

iGormilhit
Copy link

  • NEW: add a npm library for sticky autohide header
  • BETTER: add a rule for SASS in editorconfig
  • BETTER: extend the sidebar the height
  • BETTER: reorder the my account items menu
  • FIX: fix cover size
  • FIX: reimplement navbar inverse colors
  • FIX: place correctly main content under the header
  • FIX: fix the profile layout
  • FIX: fix the frontpage upper section
  • FIX: restore the 16px base font-size

Co-Authored-by: Igor Milhit [email protected]
Co-Authored-by: Nicolas Labat [email protected]


To test

  • get the PR branch
  • ./scripts/bootstrap (maybe you'll need setup too, if you still don't have patron type fixtures
  • observe the UI
  • run the tests

⚠️ There still some issue, obviously, on the general layout. I'm on the process to open an issue to list everything: #121

* NEW: add a npm library for sticky autohide header
* BETTER: add a rule for SASS in editorconfig
* BETTER: extend the sidebar the height
* BETTER: reorder the *my account* items menu
* FIX: fix cover size
* FIX: reimplement navbar inverse colors
* FIX: place correctly main content under the header
* FIX: fix the profile layout
* FIX: fix the frontpage upper section
* FIX: restore the 16px base font-size

Co-Authored-by: Igor Milhit <[email protected]>
Co-Authored-by: Nicolas Labat <[email protected]>
@iGormilhit iGormilhit merged commit 603786a into rero:master Oct 18, 2018
@iGormilhit iGormilhit deleted the header-side-bar branch October 18, 2018 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants