Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v0.12.0rc #1210

Merged
merged 1 commit into from
Sep 14, 2020
Merged

release: v0.12.0rc #1210

merged 1 commit into from
Sep 14, 2020

Conversation

iGormilhit
Copy link

Why are you opening this PR?

For the v0.12.0 release

How to test?

  • Check the changes files.
  • Have a look to the RELEASE-NOTES.rst file.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@iGormilhit iGormilhit self-assigned this Sep 10, 2020
@iGormilhit iGormilhit requested a review from mmo September 10, 2020 07:13
@iGormilhit iGormilhit added the dev: documentation About changelog, release notes, installation procedures, gh templates... label Sep 10, 2020
@iGormilhit iGormilhit added this to the v0.12.0 milestone Sep 10, 2020
@iGormilhit iGormilhit changed the title release: v0.12.0 release: v0.12.0rc Sep 10, 2020
@iGormilhit iGormilhit marked this pull request as ready for review September 10, 2020 09:31
@iGormilhit iGormilhit requested a review from BadrAly September 10, 2020 09:31
Copy link
Contributor

@mmo mmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouff!

- Replaces the legacy ``authors`` by ``contribution`` filed in the
search results view (brief view), detailed view and the loan
transaction history of the public and professional interface. In the
same move, the search input in the document editor, to link a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
same move, the search input in the document editor, to link a
same move, the search input in the document editor, that allows to link a

that has been renewed is checked in.
- Replaces the pickup location name by the item’s library name of
the item details.
- Adds an alert message to inform the librarian the destination of a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Adds an alert message to inform the librarian the destination of a
- Adds an alert message to inform the librarian of the destination of a

- Fills the document editor with the data of a record imported
through an external client using the REST API. As the librarian
saves the record, the ``_draft`` boolean field is set to false to
allow it’s validation (see below, in the `API`_ section).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
allow it’s validation (see below, in the `API`_ section).
allow its validation (see below, in the `API`_ section).

- Uses ``datetime`` to manage start and end date fields of the loans in
``rero-ils``, since ``invenio-circulation`` ``v1.0.0a21`` uses
``date`` format.
- Implements `circulation actions`_, after an effort to modelize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Implements `circulation actions`_, after an effort to modelize
- Implements `circulation actions`_, after an effort to

``rero-ils``, since ``invenio-circulation`` ``v1.0.0a21`` uses
``date`` format.
- Implements `circulation actions`_, after an effort to modelize
extensively all circulation use cases, for library network complex
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
extensively all circulation use cases, for library network complex
extensively model all circulation use cases, for library network complex

- Improves ``marc21tojson`` transformations with a better
identification of empty values, and their replacement with default
values.
- Allows (temporarily) to attached to a document of journal type or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nouvelle proposition de paragraphe:

Allows (temporarily) to attach a serial holdings or a standard holdings to a document of journal type or periodical issuance type. This is necessary for migrating all the legacy system records to RERO ILS.

library website (or elsewhere), that points to a RERO ILS search
result presenting the list.
- Adds a search input in the order line editor to find a specific
document and to save the librarian the burden to type the full REST
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
document and to save the librarian the burden to type the full REST
document and to save the librarian the burden of typing the full REST

~~~

- Adds ``marcxml`` support to the document API, thus allowing
authenticated user to post ``marcxml`` records using an external
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
authenticated user to post ``marcxml`` records using an external
an authenticated user to post ``marcxml`` records using an external

Permission
~~~~~~~~~~

- Adds the ``document_importer`` role for user that post records
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Adds the ``document_importer`` role for user that post records
- Adds the ``document_importer`` role to users posting records

~~~~~

- Adds fixture data for end to end (e2e) tests with `Cypress`_.
- Splits ``commands.js`` `file`_) into multiple files to improve its
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file_) -> à corriger

CHANGES.rst Outdated

**Fixed bugs:**

- message ’prêt impossible : l’exemplaire est demandé par un autre
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing ` at the end of "’prêt impossible"

Copy link
Author

@iGormilhit iGormilhit Sep 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BadrAly This has been automatically fetched from the #1160 title. 😃

I'm going to change the issue title and regenerate the changelog amend the file as you've suggested. Thanks.

Co-Authored-by: Igor Milhit <[email protected]>
@iGormilhit iGormilhit merged commit 9f37bc2 into rero:dev Sep 14, 2020
@iGormilhit iGormilhit deleted the release-12 branch September 15, 2020 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: documentation About changelog, release notes, installation procedures, gh templates...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants