data: reorganisation of json schema. #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerowep
force-pushed
the
wep-#1660-fix-json-schema-numbering-script
branch
from
09cc4a4 to
2c2229e
Compare
Reorganizes `numbering_script` from `common/languages-v0.0.1.json` to `documents/document_series-v0.0.1.json`. * closes rero#1147 Co-Authored-by: Peter Weber <[email protected]>
rerowep
force-pushed
the
wep-#1660-fix-json-schema-numbering-script
branch
from
2c2229e to
e95030e
Compare
BadrAly
approved these changes
Aug 14, 2020
iGormilhit
approved these changes
Aug 17, 2020
jma
approved these changes
Aug 17, 2020
| "numbering_script": { | ||
| "title": "Values", | ||
| "type": "object", | ||
| "propertiesOrder": [ |
There was a problem hiding this comment.
additionalProperties is missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganizes
numbering_scriptfromcommon/languages-v0.0.1.jsonto
documents/document_series-v0.0.1.json.Co-Authored-by: Peter Weber [email protected]
Why are you opening this PR?
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?
Code review check list