Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: marc21json cli function to use splitted json schemas #1120

Merged
merged 1 commit into from
Aug 4, 2020
Merged

cli: marc21json cli function to use splitted json schemas #1120

merged 1 commit into from
Aug 4, 2020

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Jul 29, 2020

  • Fixes the marc21json cli function to work proberly with json schema files with $refs.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@rerowep rerowep requested review from jma, iGormilhit and BadrAly July 29, 2020 20:33
@rerowep rerowep self-assigned this Jul 29, 2020
@rerowep rerowep force-pushed the web-fix-marc21json-cli branch 2 times, most recently from 66c0c69 to 59e9041 Compare July 30, 2020 06:04
@rerowep rerowep marked this pull request as draft July 30, 2020 06:31
@rerowep rerowep force-pushed the web-fix-marc21json-cli branch 3 times, most recently from b066978 to 56139d8 Compare July 30, 2020 11:20
@rerowep rerowep marked this pull request as ready for review July 30, 2020 11:59
@rerowep rerowep force-pushed the web-fix-marc21json-cli branch 5 times, most recently from f3df617 to 1142f2e Compare July 31, 2020 12:15
@rerowep rerowep requested a review from Garfield-fr August 4, 2020 06:57
@jma
Copy link
Contributor

jma commented Aug 4, 2020

Please check you commit message.

@rerowep
cli: fix marc21 to json transformation
0846e7d 
* Fixes the marc21json and validate cli functions to work properly with
  json schema files containing $refs.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the web-fix-marc21json-cli branch from 1142f2e to 0846e7d Compare August 4, 2020 10:11
@rerowep rerowep merged commit 2257bac into rero:dev Aug 4, 2020
@rerowep rerowep deleted the web-fix-marc21json-cli branch August 24, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BadrAly BadrAly BadrAly approved these changes

@zannkukai zannkukai zannkukai approved these changes

@jma jma Awaiting requested review from jma

@iGormilhit iGormilhit Awaiting requested review from iGormilhit

@benerken benerken Awaiting requested review from benerken

@Garfield-fr Garfield-fr Awaiting requested review from Garfield-fr

@lauren-d lauren-d Awaiting requested review from lauren-d

Assignees

@rerowep rerowep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rerowep @jma @Garfield-fr @zannkukai @BadrAly