frontend: refactor layout #107

jma · 2018-10-09T13:34:17Z

BETTER: css and js bundles
BETTER: include reroils-record-editor in the app
BETTER: editor views based on Invenio-Admin
NEW: professional sidebar
BETTER: refactor header layout
BETTER: reduce the number of search jinja templates

Co-Authored-by: Johnny Mariéthoz [email protected]
Co-Authored-by: Igor Milhit [email protected]

Note:

draft version of the prof. sidebar

Tests:

pipenv run pip uninstall reroils-record-editor and pipenv run pip install -e .[all]
./scripts/bootstrap, ./scripts/setup, ./scripts/server or adapt your own
url interface: https://localhost:5000

iGormilhit

Some links have to be updated:

from the patrons brief and detailed view to the circulation module, and when possible use a url_for.

iGormilhit · 2018-10-09T16:22:39Z

rero_ils/modules/utils.py

+# waive the privileges and immunities granted to it by virtue of its status
+# as an Intergovernmental Organization or submit itself to any jurisdiction.
+
+"""Utilities for reroils-record-editor."""


Change Docstring.

Garfield-fr · 2018-10-10T06:11:35Z

Header menu: Blue on blue is not good. we can't see well. Change with white color.

Garfield-fr · 2018-10-10T06:12:24Z

Header: The logo is smaller than before

Garfield-fr · 2018-10-10T06:14:29Z

Header menu: The "menu" menu is not the right term, because it contains languages. Change with "Languages" or other and extract help to another place.

Garfield-fr · 2018-10-10T06:16:00Z

Homepage: The white writing on the image has changed. Characters too small.

Garfield-fr · 2018-10-10T06:17:23Z

Layout: With the admin menu, the whole presentation is shifted to the right.

Garfield-fr · 2018-10-10T06:20:12Z

Homepage: The red banner with the development text is too small.

Garfield-fr · 2018-10-10T06:21:38Z

rero_ils/modules/admin.py

+# -*- coding: utf-8 -*-
+#
+# This file is part of Invenio.
+# Copyright (C) 2017 RERO.


rerowep

Warnings display to improve

rerowep · 2018-10-10T06:16:25Z

rero_ils/modules/documents_items/static/templates/rero_ils/brief_view_documents_items.html

@@ -1,9 +1,9 @@
 <ul class="re-list">
    <li ng-controller="recordController" ng-init="rec=record" ng-repeat="record in vm.invenioSearchResults.hits.hits track by record.id">
-      <div class="col-xs-1">
+      <div class="col-xs-2">
        <icon-thumbnail class="thumb-brief" identifiers="{{ record.metadata.identifiers }}" type="{{ record.metadata.type }}" config="{{ config }}"></icon-thumbnail>


record.metadata.identifiers not defined for new records

That was a bug from 2eb9bde

@rerowep But does this issue affect the brief view rendering?

rero_ils/modules/documents_items/templates/rero_ils/detailed_view_documents_items.html

Garfield-fr · 2018-10-10T06:24:31Z

rero_ils/modules/admin.py

+# waive the privileges and immunities granted to it by virtue of its status
+# as an Intergovernmental Organization or submit itself to any jurisdiction.
+
+"""reroils record editor."""


remove reroils term. Change with "Record editor."

Garfield-fr · 2018-10-10T06:25:24Z

rero_ils/modules/babel_extractors.py

+# -*- coding: utf-8 -*-
+#
+# This file is part of Invenio.
+# Copyright (C) 2017 RERO.


Garfield-fr · 2018-10-10T06:26:01Z

rero_ils/modules/babel_extractors.py

+# waive the privileges and immunities granted to it by virtue of its status
+# as an Intergovernmental Organization or submit itself to any jurisdiction.
+
+"""reroils translation json utils."""


remove reroils term. Change with "Translation json utils."

Garfield-fr · 2018-10-10T06:32:17Z

rero_ils/modules/items/templates/rero_ils/circulation_ui.html

-    <base href="/items/circulation">
+{%- extends 'admin/master.html' %}
+  {%- block head_meta %}
+    <base href="/admin/circulation">


Garfield-fr · 2018-10-10T06:33:08Z

rero_ils/modules/items/views.py

-    """Angular circulation application."""
-    return render_template('rero_ils/circulation_ui.html')
-
-
 def item_view_method(pid, record, template=None, **kwargs):
    r"""Display default view.


r before " ?

@Garfield-fr It seems to be a way to allow \ in Docstrings.

Garfield-fr · 2018-10-10T06:49:08Z

rero_ils/templates/rero_ils/javascript.html

@@ -0,0 +1,9 @@
+{# -*- coding: utf-8 -*-
+
+  This file is part of Invenio.


This file is part of RERO ILS.

Garfield-fr · 2018-10-10T06:49:28Z

rero_ils/templates/rero_ils/javascript.html

+{# -*- coding: utf-8 -*-
+
+  This file is part of Invenio.
+  Copyright (C) 2015-2018 CERN.


Garfield-fr · 2018-10-10T06:49:47Z

rero_ils/templates/rero_ils/page.html

-{% extends 'invenio_theme/page.html' %}
+{# -*- coding: utf-8 -*-
+
+  This file is part of Invenio.


This file is part of RERO ILS.

Garfield-fr · 2018-10-10T06:49:57Z

rero_ils/templates/rero_ils/page_cover.html

@@ -0,0 +1,69 @@
+{# -*- coding: utf-8 -*-
+
+  This file is part of Invenio.


This file is part of RERO ILS.

Garfield-fr · 2018-10-10T06:50:11Z

rero_ils/templates/rero_ils/page_cover.html

+{# -*- coding: utf-8 -*-
+
+  This file is part of Invenio.
+  Copyright (C) 2015-2018 CERN.


Garfield-fr · 2018-10-11T10:50:30Z

rero_ils/filter.py

+    """Evaluate if the resource can be created."""
+    adm = current_app.extensions['invenio-admin'].admin
+
+    def get_admin_view(record_type, menus):


def ident isn't good

Garfield-fr · 2018-10-11T10:50:42Z

rero_ils/filter.py

+    adm = current_app.extensions['invenio-admin'].admin
+
+    def get_admin_view(record_type, menus):
+        """."""


Missing docstring

Garfield-fr · 2018-10-11T10:54:26Z

rero_ils/permissions.py

+
+
+def admin_permission_factory(admin_view):
+    """."""


Missing docstring

rerowep · 2018-10-11T11:12:39Z

Needs max width or responsive image width.

* BETTER: css and js bundles * BETTER: include reroils-record-editor in the app * BETTER: editor views based on Invenio-Admin * NEW: professional sidebar * BETTER: refactor header layout * BETTER: reduce the number of search jinja templates * FIX: closes rero#109 Co-Authored-by: Johnny Mariéthoz <[email protected]> Co-Authored-by: Igor Milhit <[email protected]> Signed-off-by: Igor Milhit <[email protected]>

jma requested review from Garfield-fr and rerowep October 9, 2018 13:34

jma force-pushed the header-top-menu branch 2 times, most recently from 45a9321 to e82cfe7 Compare October 9, 2018 15:41

iGormilhit suggested changes Oct 10, 2018

View reviewed changes

Garfield-fr reviewed Oct 10, 2018

View reviewed changes

rerowep requested changes Oct 10, 2018

View reviewed changes

Garfield-fr reviewed Oct 10, 2018

View reviewed changes

jma force-pushed the header-top-menu branch from e82cfe7 to 35b323b Compare October 11, 2018 06:14

iGormilhit approved these changes Oct 11, 2018

View reviewed changes

Garfield-fr approved these changes Oct 11, 2018

View reviewed changes

rerowep approved these changes Oct 11, 2018

View reviewed changes

jma force-pushed the header-top-menu branch from 35b323b to 970a4ea Compare October 11, 2018 14:48

jma force-pushed the header-top-menu branch from 970a4ea to 03bcd7a Compare October 11, 2018 16:26

jma merged commit 0fd2b8a into rero:master Oct 11, 2018

jma deleted the header-top-menu branch November 28, 2018 06:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

frontend: refactor layout #107

frontend: refactor layout #107

jma commented Oct 9, 2018 •

edited

Loading

iGormilhit left a comment

iGormilhit Oct 9, 2018

Garfield-fr commented Oct 10, 2018

Garfield-fr commented Oct 10, 2018

Garfield-fr commented Oct 10, 2018

Garfield-fr commented Oct 10, 2018

Garfield-fr commented Oct 10, 2018

Garfield-fr commented Oct 10, 2018

Garfield-fr Oct 10, 2018

rerowep left a comment

rerowep Oct 10, 2018

iGormilhit Oct 10, 2018

iGormilhit Oct 10, 2018

Garfield-fr Oct 10, 2018

Garfield-fr Oct 10, 2018

Garfield-fr Oct 10, 2018

Garfield-fr Oct 10, 2018

Garfield-fr Oct 10, 2018

iGormilhit Oct 10, 2018

Garfield-fr Oct 10, 2018

Garfield-fr Oct 10, 2018

Garfield-fr Oct 10, 2018

Garfield-fr Oct 10, 2018

Garfield-fr Oct 10, 2018

Garfield-fr Oct 11, 2018

Garfield-fr Oct 11, 2018

Garfield-fr Oct 11, 2018

rerowep commented Oct 11, 2018

		@@ -0,0 +1,9 @@
		{# -- coding: utf-8 --

		This file is part of Invenio.

		@@ -0,0 +1,69 @@
		{# -- coding: utf-8 --

		This file is part of Invenio.

frontend: refactor layout #107

frontend: refactor layout #107

Conversation

jma commented Oct 9, 2018 • edited Loading

iGormilhit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Garfield-fr commented Oct 10, 2018

Garfield-fr commented Oct 10, 2018

Garfield-fr commented Oct 10, 2018

Garfield-fr commented Oct 10, 2018

Garfield-fr commented Oct 10, 2018

Garfield-fr commented Oct 10, 2018

Choose a reason for hiding this comment

rerowep left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rerowep commented Oct 11, 2018

jma commented Oct 9, 2018 •

edited

Loading