Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error not specified at patron creation #9

Closed
pronguen opened this issue Apr 24, 2018 · 3 comments
Closed

Error not specified at patron creation #9

pronguen opened this issue Apr 24, 2018 · 3 comments
Assignees
Labels
effort: minor Solved quickly f: editor Concerns editor based on JSON schema AND custom editor
Milestone

Comments

@pronguen
Copy link
Contributor

When I create a patron, I cannot save it because of an unknown error (see screenshot).
unknown_error

@iGormilhit
Copy link

iGormilhit commented Apr 24, 2018

@pronguen I think it's related to the date. This field has a "format": "date" which, apparently, doesn't accept 9999-99-99.

Edit: Year 9999 is possible, of course, but Month > 12 and Day > 31 aren't.

At least, a better validation message should be provided.

@iGormilhit iGormilhit added the enhancement Improvement of an existing feature label Apr 24, 2018
@pronguen
Copy link
Contributor Author

pronguen commented May 3, 2018

Could you please:

  • change the regex (for ex. ^\d{4}(-(0[1-9]|1[0-2]))(-(0[1-9]|[1-2][0-9]|3[0-1]))$)
  • add an error message, just in the case a wrong date is not checked by the regex (like 2018-02-30)?

@iGormilhit iGormilhit added this to the v.0.1.0a16 milestone Jun 28, 2018
@iGormilhit iGormilhit added effort: minor Solved quickly f: editor Concerns editor based on JSON schema AND custom editor and removed enhancement Improvement of an existing feature labels Jun 28, 2018
iGormilhit pushed a commit to rero/reroils-data-legacy that referenced this issue Jul 2, 2018
@iGormilhit
Copy link

How to test:

  1. Checkout into the branch
  2. Review the commit
  3. Create a user (user, patron, staff) and see how the birth date is validating

@iGormilhit iGormilhit self-assigned this Jul 2, 2018
iGormilhit pushed a commit to rero/reroils-data-legacy that referenced this issue Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: minor Solved quickly f: editor Concerns editor based on JSON schema AND custom editor
Projects
None yet
Development

No branches or pull requests

2 participants