Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two loans instead of one #484

Closed
BadrAly opened this issue Sep 6, 2019 · 0 comments
Closed

Two loans instead of one #484

BadrAly opened this issue Sep 6, 2019 · 0 comments
Labels
f: circulation Concerns the circulation interface or backend

Comments

@BadrAly
Copy link

BadrAly commented Sep 6, 2019

When a patron requests then checkouts out an item, the system creates two loans instead of one

Steps to reproduce the behavior:

  1. A patron places a request on an item to pickup at an external library, system creates a loan (pid 1 for example) with a state PENDING
  2. A librarian sends the item to the pickup library, the loan state become IN_TRANSIT_FOR_PICKUP
  3. A librarian receives the item at the destination library, the loan state becomes ITEM_AT_DESK
  4. A librarian checks out the item to a patron, the loan state becomes CANCELLED and a new loan (pid=2) is created with state ON_LOAN

Expected behavior
System should continue to work on the first loan and never creates a new loan.

@BadrAly BadrAly added bug f: circulation Concerns the circulation interface or backend labels Sep 6, 2019
benerken pushed a commit to benerken/rero-ils that referenced this issue Sep 10, 2019
benerken pushed a commit to benerken/rero-ils that referenced this issue Sep 12, 2019
lauren-d pushed a commit to benerken/rero-ils that referenced this issue Sep 12, 2019
lauren-d pushed a commit to benerken/rero-ils that referenced this issue Sep 12, 2019
lauren-d pushed a commit to benerken/rero-ils that referenced this issue Sep 12, 2019
benerken pushed a commit to benerken/rero-ils that referenced this issue Sep 13, 2019
* Fix issue rero#484
* Move function prior_checkout_actions() from api_views.py to api.py

Co-Authored-by: Benoit Erken [email protected]
benerken pushed a commit to benerken/rero-ils that referenced this issue Sep 16, 2019
* Closes rero#484
* Move function prior_checkout_actions() from api_views.py to api.py

Co-Authored-by: Benoit Erken [email protected]
benerken pushed a commit to benerken/rero-ils that referenced this issue Sep 16, 2019
* Closes rero#484
* Move function prior_checkout_actions() from api_views.py to api.py

Co-Authored-by: Benoit Erken [email protected]
benerken pushed a commit to benerken/rero-ils that referenced this issue Sep 17, 2019
* Closes rero#484
* Move function prior_checkout_actions() from api_views.py to api.py

Co-Authored-by: Benoit Erken [email protected]
benerken added a commit to benerken/rero-ils that referenced this issue Sep 18, 2019
* Closes rero#484
* Moves prior_checkout_actions() function from api_views.py to api.py

Co-Authored-by: Benoit Erken <[email protected]>
benerken added a commit to benerken/rero-ils that referenced this issue Sep 19, 2019
* Closes rero#484
* Moves prior_checkout_actions() function from api_views.py to api.py

Co-Authored-by: Benoit Erken <[email protected]>
benerken added a commit to benerken/rero-ils that referenced this issue Sep 20, 2019
* Closes rero#484
* Moves prior_checkout_actions() function from api_views.py to api.py

Co-Authored-by: Benoit Erken <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: circulation Concerns the circulation interface or backend
Projects
None yet
Development

No branches or pull requests

1 participant