Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow more than two barcodes per patron #3745

Closed
PascalRepond opened this issue Sep 3, 2024 · 0 comments · Fixed by #3746
Closed

Allow more than two barcodes per patron #3745

PascalRepond opened this issue Sep 3, 2024 · 0 comments · Fixed by #3746
Labels
developers From a developer point of view. enhancement Improvement of an existing feature

Comments

@PascalRepond
Copy link
Contributor

PascalRepond commented Sep 3, 2024 •
edited
Loading

How it works

The list for patron.patron.barcode is currently limited to 2 items. This causes problems when loading new users from files. Sometimes they have already 2 barcodes and we cannot add a third.

Improvement suggestion

Remove "maxItems: 2" in patron.patron.barcode or extend the limit to 5 barcodes.
@PascalRepond PascalRepond added the enhancement Improvement of an existing feature label Sep 3, 2024
@PascalRepond PascalRepond added the developers From a developer point of view. label Sep 3, 2024
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Sep 3, 2024
@PascalRepond
fix(patron barcodes): extend the number of barcodes
acc5b92 
* Closes rero#3745.

Co-Authored-by: Pascal Repond <[email protected]>
@PascalRepond PascalRepond mentioned this issue Sep 3, 2024
Merged
@PascalRepond PascalRepond changed the title Remove limit for patron number of barcodes Allow more than two barcodes per patron Sep 3, 2024
PascalRepond added a commit that referenced this issue Sep 23, 2024
@PascalRepond
fix(patron barcodes): extend the number of barcodes
0885253 
* Closes #3745.

Co-Authored-by: Pascal Repond <[email protected]>
@github-project-automation github-project-automation bot moved this from Ready to test to Done in RERO ILS issues Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
developers From a developer point of view. enhancement Improvement of an existing feature
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(patron barcodes): extend the number of barcodes PascalRepond/rero-ils
1 participant
@PascalRepond