Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIP2 returns None for a user/patron with any missing address field #3727

Closed
PascalRepond opened this issue Jul 24, 2024 · 0 comments · Fixed by #3739
Closed

SIP2 returns None for a user/patron with any missing address field #3727

PascalRepond opened this issue Jul 24, 2024 · 0 comments · Fixed by #3739
Assignees
@rerowep
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend

Comments

@PascalRepond
Copy link
Contributor

PascalRepond commented Jul 24, 2024 •
edited
Loading

Bug description:

If a user is missing an address field (street, postal_code, or city), there is an error in the function format_patron_address(patron) when trying to strip those fields. This prevents the user data to be returned correctly for SIP2.

Expected behavior:

  • Allow patron info to be returned correctly even if the patron has no address fields.

Steps to Reproduce:

  1. Create a patron without an address
  2. Try to get patron_information from SIP2
  3. See that it returns None
@PascalRepond PascalRepond added the bug Breaks something but is not blocking label Jul 24, 2024
@PascalRepond PascalRepond added the f: circulation Concerns the circulation interface or backend label Jul 24, 2024
@PascalRepond PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues Jul 24, 2024
@PascalRepond PascalRepond changed the title SIP2 returns None for a user/patron with any missing addres field SIP2 returns None for a user/patron with any missing address field Jul 30, 2024
@rerowep rerowep self-assigned this Aug 28, 2024
rerowep added a commit to rerowep/rero-ils that referenced this issue Aug 28, 2024
@rerowep
sip2: fix format_patron_address
6693c03 
* Closes rero#3727.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep mentioned this issue Aug 28, 2024
Merged
rerowep added a commit to rerowep/rero-ils that referenced this issue Aug 28, 2024
@rerowep
sip2: fix format_patron_address
65b6f54 
* Closes rero#3727.
* Dependencies update.

Co-Authored-by: Peter Weber <[email protected]>
@PascalRepond PascalRepond moved this from Product Backlog to In Development in RERO ILS issues Aug 29, 2024
rerowep added a commit to rerowep/rero-ils that referenced this issue Aug 29, 2024
@rerowep
sip2: fix format_patron_address
424fa4d 
* Closes rero#3727.
* Dependencies update.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Aug 29, 2024
@rerowep
sip2: fix format_patron_address
bc67a71 
* Closes rero#3727.
* Dependencies update.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Sep 2, 2024
@rerowep
sip2: fix format_patron_address
3f3fd63 
* Closes rero#3727.
* Dependencies update.

Co-Authored-by: Peter Weber <[email protected]>
PascalRepond pushed a commit that referenced this issue Sep 3, 2024
@rerowep @PascalRepond
sip2: fix format_patron_address
b903ec5 
* Closes #3727.
* Dependencies update.

Co-Authored-by: Peter Weber <[email protected]>
@PascalRepond PascalRepond moved this from Ready to test to In testing in RERO ILS issues Sep 3, 2024
rerowep added a commit that referenced this issue Sep 4, 2024
@rerowep
sip2: fix format_patron_address
d46f0ee 
* Closes #3727.
* Dependencies update.

Co-Authored-by: Peter Weber <[email protected]>
@github-project-automation github-project-automation bot moved this from In testing to Done in RERO ILS issues Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rerowep rerowep

Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sip2: fix format_patron_address rerowep/rero-ils
2 participants
@rerowep @PascalRepond