Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document editor: impossible to select one role if the field was unselected #3712

Closed
PascalRepond opened this issue Jul 2, 2024 · 1 comment · Fixed by rero/ng-core#629
Closed

Document editor: impossible to select one role if the field was unselected #3712

PascalRepond opened this issue Jul 2, 2024 · 1 comment · Fixed by rero/ng-core#629
Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor

Comments

@PascalRepond
Copy link
Contributor

Bug description:

In the contribution field, if I unselect all roles and then select one role, the validator doesn't let me save because it says role needs at least one value.

Expected behavior:

If one value is selected, the editor should be savable.

Steps to Reproduce:

  1. Edit any document
  2. In the contributor field, unselect the roles so that it says "select an option..."
  3. Try to save, validator error.

Context

  • Versions: 1.22.1
  • Probably linked to formly 6.3.X?
@PascalRepond PascalRepond added the bug Breaks something but is not blocking label Jul 2, 2024
@PascalRepond PascalRepond moved this from Inbox to Sprint backlog in RERO ILS issues Jul 2, 2024
@PascalRepond PascalRepond added the f: editor Concerns editor based on JSON schema AND custom editor label Jul 2, 2024
@PascalRepond
Copy link
Contributor Author

Depends on ngx-formly/ngx-formly#3958

@PascalRepond PascalRepond moved this from Sprint backlog to Ready to test in RERO ILS issues Jul 16, 2024
@PascalRepond PascalRepond moved this from Ready to test to In testing in RERO ILS issues Jul 17, 2024
PascalRepond added a commit to PascalRepond/ng-core that referenced this issue Jul 17, 2024
@PascalRepond
fix: update ngx-formly
feb7c8e 
- Closes rero/rero-ils#3712
- Closes rero/rero-ils#3705

Co-Authored-by: Pascal Repond <[email protected]>
@PascalRepond PascalRepond mentioned this issue Jul 17, 2024
Merged
@github-project-automation github-project-automation bot moved this from In testing to Done in RERO ILS issues Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update ngx-formly PascalRepond/ng-core
1 participant
@PascalRepond