Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pro patron history: checkout and renewal info missing #3529

Closed
PascalRepond opened this issue Nov 16, 2023 · 0 comments · Fixed by rero/rero-ils-ui#1084
Closed

Pro patron history: checkout and renewal info missing #3529

PascalRepond opened this issue Nov 16, 2023 · 0 comments · Fixed by rero/rero-ils-ui#1084
Assignees
@Garfield-fr
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend

Comments

@PascalRepond
Copy link
Contributor

Bug description:

In the professionnal patron history, if a loan had at least one notification linked, the checkout info (date and transaction location) is not displayed and creates an error in the console: e.checkout.metadata is undefined

Expected behavior:

The checkout date and location should be correctly displayed without error.

Steps to Reproduce:

  1. Go to a user with a loan that has already had a notification
  2. Check in the item
  3. Go to the patron history and try to open the loan
  4. See error and missing info

Example: https://ils.test.rero.ch/professional/circulation/patron/2050124312/history : Open "Les genres musicaux"

Context

  • Versions: v1.19.0
@PascalRepond PascalRepond added f: circulation Concerns the circulation interface or backend bug Breaks something but is not blocking labels Nov 16, 2023
@PascalRepond PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues Nov 16, 2023
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Nov 27, 2023
@Garfield-fr
circulation: fix patron history
e07636a 
* Closes rero/rero-ils#3529.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Nov 27, 2023
Merged
@Garfield-fr Garfield-fr moved this from Product Backlog to In Development in RERO ILS issues Nov 27, 2023
@Garfield-fr Garfield-fr self-assigned this Nov 27, 2023
@Garfield-fr Garfield-fr moved this from In Development to Ready to test in RERO ILS issues Nov 27, 2023
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Nov 28, 2023
@Garfield-fr
circulation: fix patron history
3bcc480 
* Closes rero/rero-ils#3529.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr moved this from Ready to test to In testing in RERO ILS issues Nov 28, 2023
@PascalRepond PascalRepond moved this from In testing to Approved in RERO ILS issues Nov 29, 2023
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Dec 6, 2023
@Garfield-fr
circulation: fix patron history
baba61d 
For the patrons's history we only retrieve the loan type.

* Closes rero/rero-ils#3529.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Dec 6, 2023
@Garfield-fr
circulation: fix patron history
cd8d774 
For the patrons's history we only retrieve the loan type.

* Closes rero/rero-ils#3529.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@github-project-automation github-project-automation bot moved this from Approved to Done in RERO ILS issues Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

circulation: fix patron history Garfield-fr/rero-ils-ui
2 participants
@Garfield-fr @PascalRepond