Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress the 'acquisition_order' field in the library notification setting #3241

Closed
ManaDeweerdt opened this issue Feb 1, 2023 · 1 comment · Fixed by rero/rero-ils-ui#935
Closed

Suppress the 'acquisition_order' field in the library notification setting #3241

ManaDeweerdt opened this issue Feb 1, 2023 · 1 comment · Fixed by rero/rero-ils-ui#935
Assignees
@zannkukai
Labels
correction An implemented feature doesn't work as expected. f: acquisitions Related to the acquisition module f: professional ui Professional interface p-Low Low priority

Comments

@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Feb 1, 2023 •
edited
Loading

How it works

The acquisition_order notification type in library notification settings is not used.
The order is sent according to the email contact in the acquisition setting.

Improvement suggestion

The field acquisition_order in the library notification settings is suppressed.
@ManaDeweerdt ManaDeweerdt added f: professional ui Professional interface f: acquisitions Related to the acquisition module p-Low Low priority correction An implemented feature doesn't work as expected. labels Feb 1, 2023
@zannkukai
Copy link
Contributor

zannkukai commented Feb 6, 2023 •
edited
Loading

The acquisition_order is a valid and used notification type : it can't be deleted.
But the UI editor doesn't need to create a field for acquisition_order email because the email used when sending an order notification is either :

  • related vendor email
  • related library acquisition_setting email
  • custom email chosed by manager

delete acquisition_order field

image

@ManaDeweerdt ManaDeweerdt changed the title Suppress the notification type 'acquisition_order' Suppress the 'acquisition_order' field in the library notification setting Feb 6, 2023
@zannkukai zannkukai self-assigned this Feb 6, 2023
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Feb 6, 2023
@zannkukai
library: fix editor
29c94ad 
* Closes rero/rero-ils#3241.
* Closes rero/rero-ils#3159.

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai mentioned this issue Feb 6, 2023
Merged
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Feb 6, 2023
@zannkukai
library: fix editor
1efd4d0 
* Closes rero/rero-ils#3241.
* Closes rero/rero-ils#3159.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Feb 8, 2023
@zannkukai
library: fix editor
4c2a6c1 
* Closes rero/rero-ils#3241.
* Closes rero/rero-ils#3159.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to rero/rero-ils-ui that referenced this issue Feb 13, 2023
@zannkukai
library: fix editor
fd07e38 
* Closes rero/rero-ils#3241.
* Closes rero/rero-ils#3159.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Feb 20, 2023
@zannkukai
library: fix editor
e41bec2 
* Closes rero/rero-ils#3241.
* Closes rero/rero-ils#3159.

Co-Authored-by: Renaud Michotte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
correction An implemented feature doesn't work as expected. f: acquisitions Related to the acquisition module f: professional ui Professional interface p-Low Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

library: fix editor zannkukai/rero-ils-ui
2 participants
@zannkukai @ManaDeweerdt