Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter simple=1 should be hidden from the interface in the public view #3094

Closed
pronguen opened this issue Sep 14, 2022 · 2 comments · Fixed by rero/ng-core#524
Closed
Labels
correction An implemented feature doesn't work as expected. f: public ui Public interface, as opposed to the professional interface f: search p-Medium Medium priority (to be solved within 1-2 years)

Comments

@pronguen
Copy link
Contributor

pronguen commented Sep 14, 2022

How it works

When doing an expert search in the public interface, the filtre "0" is displayed on top of the result list.

image

To reproduce: open this search

This happens when displaying the linked articles from a periodical (implementation of #3006) or when opening a link to the catalogue exploiting expert search (for instance for new acquisitions).

In the professional interface, the parameter doesn't appear (it is already ok!).

Improvement suggestion

This specific parameter is hidden as filter.

@pronguen pronguen added correction An implemented feature doesn't work as expected. effort: minor Solved quickly f: public ui Public interface, as opposed to the professional interface p-High High priority (to be solved in the 2-3 next months) f: search labels Sep 14, 2022
@PascalRepond PascalRepond added effort: important US candidate and removed effort: minor Solved quickly labels Sep 15, 2022
@PascalRepond
Copy link
Contributor

PascalRepond commented Sep 15, 2022

All filters in the URL appear on the page, as currently implemented. See : https://ilsdev.test.rero.ch/aoste/search/documents?q=identifiedBy.value:R003441826&page=1&size=10&sort=bestmatch&simple=0&toto=tutu&aurevoir=bonjour

  • A simple way to fix this would be to enable the "expert search" button in the public view, but I don't think this is what we want.
  • A complicated way would be to make the frontend check with the backend if any present filter is authorized or not, which would imply a heavy refactoring and/or more work whenver we need to add a new filter.
  • A pragmatic way to deal with this would be to consider it a feature, not a bug. 😋 This indicates if the expert search is enabled in the interface.

@pronguen pronguen added p-Medium Medium priority (to be solved within 1-2 years) and removed p-High High priority (to be solved in the 2-3 next months) effort: important US candidate needs info labels Sep 20, 2022
@pronguen
Copy link
Contributor Author

pronguen commented Sep 20, 2022

After discussion within PO group (on 20.09.22), we decided, as a pragmatic fix, to only hide the parameter simple, which is the most probable.

In this perspective, other fake parameters (like &toto=tutu&aurevoir=bonjour) would still be displayed, which is okay.

Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Oct 4, 2022
* Closes rero/rero-ils#3094.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to rero/ng-core that referenced this issue Oct 4, 2022
* Closes rero/rero-ils#3094.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to rero/ng-core that referenced this issue Oct 5, 2022
* Closes rero/rero-ils#3094.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction An implemented feature doesn't work as expected. f: public ui Public interface, as opposed to the professional interface f: search p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants