Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import duplicate check suggesting erroneous duplicates #3031

Closed
pronguen opened this issue Aug 4, 2022 · 0 comments · Fixed by rero/rero-ils-ui#899
Closed

Import duplicate check suggesting erroneous duplicates #3031

pronguen opened this issue Aug 4, 2022 · 0 comments · Fixed by rero/rero-ils-ui#899
Assignees
@Garfield-fr
Labels
bug Breaks something but is not blocking f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: professional ui Professional interface p-High High priority (to be solved in the 2-3 next months)

Comments

@pronguen
Copy link
Contributor

pronguen commented Aug 4, 2022

Bug description:

Import duplicate check suggests erroneous duplicates (since v1.12.0).

Expected behavior:

Duplicate check only suggests document containing a same identifier, especially ISBN.

Steps to Reproduce:

  1. Import from the web
  2. Type "cb319851304" in the BNF source
  3. Import the record
  4. See the suggestions from the duplicate check

Context

Server:

Version:

v1.12.0

Screenshots

image
@pronguen pronguen added bug Breaks something but is not blocking f: data About data model, importation, transformation, exportation of data, specific for bibliographic data p-High High priority (to be solved in the 2-3 next months) f: professional ui Professional interface labels Aug 4, 2022
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Sep 22, 2022
@Garfield-fr
document: improve check for document import
b4506e1 
Previously the control was done on a fixed list of types.
Now all identifiers are searched.

* Closes rero/rero-ils#3031.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Sep 22, 2022
Merged
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Sep 29, 2022
@Garfield-fr
document: improve import control
0241e0c 
If no identifier has been selected for the control,
we try to search by the main title

* Closes rero/rero-ils#3031.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Sep 29, 2022
@Garfield-fr
document: improve import control
a61de95 
If no identifier has been selected for the control,
we try to search by the main title

* Closes rero/rero-ils#3031.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Oct 3, 2022
@Garfield-fr
document: improve import control
a9a01ce 
If no identifier has been selected for the control,
we try to search by the main title

* Closes rero/rero-ils#3031.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Oct 3, 2022
@Garfield-fr
document: improve import control
797688c 
If no identifier has been selected for the control,
we try to search by the main title

* Closes rero/rero-ils#3031.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
bug Breaks something but is not blocking f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: professional ui Professional interface p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

document: improve import control Garfield-fr/rero-ils-ui
2 participants
@Garfield-fr @pronguen