Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

At_desk notification: incorrect patron info #2938

Closed
PascalRepond opened this issue May 31, 2022 · 0 comments · Fixed by #2939
Closed

At_desk notification: incorrect patron info #2938

PascalRepond opened this issue May 31, 2022 · 0 comments · Fixed by #2939
Assignees
@zannkukai
Labels
client request Issue reported by production libraries correction An implemented feature doesn't work as expected. f: notifications p-High High priority (to be solved in the 2-3 next months)

Comments

@PascalRepond
Copy link
Contributor

PascalRepond commented May 31, 2022 •
edited
Loading

How it works

The recently implemented at_desk notification sometimes displays the wrong patron if there are multiple requests on the item.

How to reproduce

  1. Request an item with two different patrons.
  2. Check in the item so that it becomes "at_desk".
  3. See that the notification sometimes shows not the first patron on the list but the second one.

Improvement suggestion

The notification doesn't seem to always take the correct patron if it gets an array.

The at_desk notification should display the patron for whom the item is available at desk, even if there are multiple request loans for different patrons on an item.
@PascalRepond PascalRepond added f: notifications correction An implemented feature doesn't work as expected. labels May 31, 2022
@PascalRepond PascalRepond added the client request Issue reported by production libraries label May 31, 2022
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Jun 1, 2022
@zannkukai
notification: fix at_desk notification context.
ea110de 
Ensures that the patron related to the `at_desk` notification is the
patron related to the AT_DESK loan state.
Closes rero#2938.

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai mentioned this issue Jun 1, 2022
Merged
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Jun 1, 2022
@zannkukai
notification: fix at_desk notification context.
e1bc4c3 
Ensures that the patron related to the `at_desk` notification is the
patron related to the AT_DESK loan state.
Closes rero#2938.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Jun 1, 2022
@zannkukai
notification: fix at_desk notification context.
e3e4c53 
Ensures that the patron related to the `at_desk` notification is the
patron related to the AT_DESK loan state.
Closes rero#2938.

Co-Authored-by: Renaud Michotte <[email protected]>
@pronguen pronguen added the p-High High priority (to be solved in the 2-3 next months) label Jun 7, 2022
zannkukai added a commit that referenced this issue Jun 9, 2022
@zannkukai
notification: fix at_desk notification context.
72f7060 
Ensures that the patron related to the `at_desk` notification is the
patron related to the AT_DESK loan state.
Closes #2938.

Co-Authored-by: Renaud Michotte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
client request Issue reported by production libraries correction An implemented feature doesn't work as expected. f: notifications p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

notification: fix at_desk notification context. zannkukai/rero-ils
3 participants
@pronguen @zannkukai @PascalRepond