Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patron account expired: improve message #2920

Closed
pronguen opened this issue May 17, 2022 · 0 comments · Fixed by #3273
Closed

Patron account expired: improve message #2920

pronguen opened this issue May 17, 2022 · 0 comments · Fixed by #3273
Assignees
@Garfield-fr
Labels
enhancement Improvement of an existing feature f: public ui Public interface, as opposed to the professional interface p-High High priority (to be solved in the 2-3 next months) UX User experience, ergonomy

Comments

@pronguen
Copy link
Contributor

pronguen commented May 17, 2022 •
edited by PascalRepond
Loading

How it works

Currently, when the patron rights expire, the patron is not anymore able to do checkouts, request and renewals. He/she doesn't know that the requests are blocked, because the warning message is displayed only on his account, not on the catalogue.

What is more, some messages are not well formatted:
image

Improvement suggestion

  • The warning message is modified, but only on the public interface
    • Patron rights expired. > Your account has expired. Please contact your library.
  • In the public UI, the request button is disabled (instead of being hidden) when a patron is blocked. With an explanation in the tooltip: Your account has expired. Please contact your library.
  • The formatting of the screenshot above is corrected

Context

Linked issue: #2867
@pronguen pronguen added enhancement Improvement of an existing feature f: public ui Public interface, as opposed to the professional interface UX User experience, ergonomy p-High High priority (to be solved in the 2-3 next months) labels May 17, 2022
@pronguen pronguen mentioned this issue May 17, 2022
Closed
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Mar 6, 2023
@Garfield-fr
patron: change message on expired account
9466a3b 
* Closes rero#2920.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Mar 6, 2023
Merged
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Mar 6, 2023
@Garfield-fr
patrons: account expired
51f4920 
The request button is displayed even if the request is not possible
with a tooltip indicating the reason.

* Fixes tooltip message with <br>.
* Fixes request button on document detail view.
* Closes rero/rero-ils#2920.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Mar 6, 2023
Closed
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Mar 6, 2023
@Garfield-fr
patrons: account expired
d318bcd 
The request button is displayed even if the request is not possible
with a tooltip indicating the reason.

* Fixes tooltip message with `<br>`.
* Fixes request button on document detail view.
* Closes rero/rero-ils#2920.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr self-assigned this Mar 6, 2023
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Mar 6, 2023
@Garfield-fr
patrons: account expired
c933c1f 
The request button is displayed even if the request is not possible
with a tooltip indicating the reason.

* Fixes tooltip message with `<br>`.
* Fixes request button on document detail view.
* Closes rero/rero-ils#2920.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Mar 7, 2023
@Garfield-fr
patron: change message on expired account
7092d7d 
* Closes rero#2920.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Mar 7, 2023
@Garfield-fr
patron: change message on expired account
f996989 
* Closes rero#2920.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Mar 8, 2023
@Garfield-fr
patron: change message on expired account
b8d9929 
* Closes rero#2920.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Mar 21, 2023
@Garfield-fr
patron: change message on expired account
6d9c251 
* Closes rero#2920.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
PascalRepond pushed a commit that referenced this issue Mar 23, 2023
@Garfield-fr @PascalRepond
patron: change message on expired account
d21505f 
* Closes #2920.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Mar 29, 2023
@Garfield-fr
patron: change message on expired account
b354042 
* Closes rero#2920.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Mar 29, 2023
@Garfield-fr
patron: change message on expired account
f891acf 
* Closes rero#2920.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Mar 29, 2023
@Garfield-fr
patron: change message on expired account
3b23ce5 
* Closes rero#2920.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Mar 29, 2023
@Garfield-fr
patron: change message on expired account
289bb03 
* Closes rero#2920.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Mar 30, 2023
@Garfield-fr
patron: change message on expired account
a0513e7 
* Closes rero#2920.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Mar 30, 2023
@Garfield-fr
patron: change message on expired account
57349e6 
* Closes rero#2920.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@PascalRepond PascalRepond moved this to In Development in RERO ILS issues Mar 30, 2023
PascalRepond pushed a commit that referenced this issue Apr 3, 2023
@Garfield-fr @PascalRepond
patron: change message on expired account
57e28b1 
* Closes #2920.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@zannkukai zannkukai moved this from In Development to Ready to test in RERO ILS issues Apr 3, 2023
@PascalRepond PascalRepond moved this from Ready to test to In testing in RERO ILS issues Apr 3, 2023
@PascalRepond PascalRepond moved this from In testing to Approved in RERO ILS issues Apr 4, 2023
PascalRepond pushed a commit that referenced this issue Apr 5, 2023
@Garfield-fr @PascalRepond
patron: change message on expired account
08050be 
* Closes #2920.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit that referenced this issue Apr 5, 2023
@Garfield-fr
patron: change message on expired account
7e86e34 
* Closes #2920.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@github-project-automation github-project-automation bot moved this from Approved to Done in RERO ILS issues Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
enhancement Improvement of an existing feature f: public ui Public interface, as opposed to the professional interface p-High High priority (to be solved in the 2-3 next months) UX User experience, ergonomy
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
2 participants
@Garfield-fr @pronguen