Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subtypes "Projected image" and "Pictorial book" to the document #2884

Closed
ThierryClavel opened this issue May 5, 2022 · 2 comments
Closed

Add subtypes "Projected image" and "Pictorial book" to the document #2884

ThierryClavel opened this issue May 5, 2022 · 2 comments
Assignees
@Garfield-fr
Labels
effort: minor Solved quickly enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years)

Comments

@ThierryClavel
Copy link

ThierryClavel commented May 5, 2022 •
edited by PascalRepond
Loading

Document editor: field type, add 2 values as subtype:

  • docsubtype_projected_image (French: Image projetée) > within main type docmaintype_image
  • docsubtype_pictorial_book (French: Livre illustré (beaux livres)) > within main type docmaintype_book
@ThierryClavel ThierryClavel added enhancement Improvement of an existing feature effort: minor Solved quickly f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years) labels May 5, 2022
@pronguen pronguen changed the title Document editor: field Type : add a subtype Document editor: field Type : add subtype "Projected image" May 17, 2022
@pronguen pronguen changed the title Document editor: field Type : add subtype "Projected image" Add subtypes "Projected image" and "Pictorial book" to the document Jun 14, 2022
@pronguen
Copy link
Contributor

corrections de masse à faire après cette issue selon PV 17 groupe metadata:
Spécifications pour les corrections de masse:

Si type de contenu, de média, support matériel = projeté
Type de contenu = image fixe
Type de support matériel = diapositive
Importance matérielle = diapositive* ou DIAPOSITIVE*
Et/ ou autres caractéristiques matérielles : ektachrome ou EKTACHROME
La catégorie type doit être : image et sous-type : image projetée.
Exemple : https://bib.rero.ch/professional/records/documents/detail/262840, https://bib.rero.ch/professional/records/documents/detail/1050939

Si type de contenu, de média, support matériel = projeté
Type de contenu = image fixe
Type de support matériel = diapositive
Importance matérielle = ektachrome* ou EKTACHROME*
La catégorie type doit être : image et sous-type : image projetée.
Exemple : https://bib.rero.ch/professional/records/documents/detail/1474383

Si type de contenu, de média, support matériel = stéréoscopique
Type de contenu = image fixe
Type de support matériel = carte stéréoscopique ou disque stéréoscopique
Importance matérielle = photographie* stéréoscopique* ou stéréoscopique*
La catégorie type doit être : image et sous-type : photographie.
Exemple : https://bib.rero.ch/professional/records/documents/detail/1390761

@pronguen pronguen mentioned this issue Jun 14, 2022
Closed
@PascalRepond
Copy link
Contributor

PascalRepond commented Jun 21, 2022 •
edited
Loading

@ThierryClavel Does this also need a dojson adaptation for imports or no?

@Garfield-fr Garfield-fr self-assigned this Jul 4, 2022
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jul 6, 2022
@Garfield-fr
documents: add 2 subtypes
a20d531 
* Adds docsubtype_projected_image on docmaintype_image.
* Adds docsubtype_pictorial_book on docmaintype_book.
* Closes rero#2884.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Jul 6, 2022
Merged
Garfield-fr added a commit that referenced this issue Jul 6, 2022
@Garfield-fr
documents: add 2 subtypes
31a9245 
* Adds docsubtype_projected_image on docmaintype_image.
* Adds docsubtype_pictorial_book on docmaintype_book.
* Closes #2884.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
zannkukai pushed a commit that referenced this issue Jul 11, 2022
@Garfield-fr @zannkukai
documents: add 2 subtypes
c790289 
* Adds docsubtype_projected_image on docmaintype_image.
* Adds docsubtype_pictorial_book on docmaintype_book.
* Closes #2884.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
effort: minor Solved quickly enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Garfield-fr @pronguen @ThierryClavel @PascalRepond